Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet): rename get_balance() to balance() #1455

Merged

Conversation

notmandatory
Copy link
Member

Description

fixes #1221

Notes to the reviewers

See discussion in #1221.

Changelog notice

Changed

  • Wallet::get_balance() renamed to Wallet::balance()

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added module-wallet api A breaking API change labels Jun 1, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Jun 1, 2024
@notmandatory notmandatory self-assigned this Jun 1, 2024
@LagginTimes
Copy link
Contributor

ACK 50137b0

@@ -1216,7 +1216,7 @@ impl Wallet {

/// Return the balance, separated into available, trusted-pending, untrusted-pending and immature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Return the balance, separated into available, trusted-pending, untrusted-pending and immature
/// Returns the balance, separated into available, trusted-pending, untrusted-pending and immature

Since we are fixing this anyways let's adjust the docstring?

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 50137b0

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 50137b0

@notmandatory notmandatory merged commit 363d9f4 into bitcoindevkit:master Jun 4, 2024
12 checks passed
@notmandatory notmandatory mentioned this pull request Jun 14, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A breaking API change module-wallet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

refactor(bdk): use idiomatic naming for all getter methods
5 participants