-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(chain)!: Change tx_last_seen to Option<u64>
#1416
Merged
notmandatory
merged 9 commits into
bitcoindevkit:master
from
ValuedMammal:fix/lastseen-none
Jul 2, 2024
Merged
refactor(chain)!: Change tx_last_seen to Option<u64>
#1416
notmandatory
merged 9 commits into
bitcoindevkit:master
from
ValuedMammal:fix/lastseen-none
Jul 2, 2024
Commits on Jun 23, 2024
-
fix(wallet)!: Rework
Wallet::insert_tx
to no longer insert anchorssince we'd be lacking context that should normally occur during sync with a chain source. The logic for inserting a graph anchor from a `ConfirmationTime` is moved to the wallet common test module in order to simulate receiving new txs and confirming them.
Configuration menu - View commit details
-
Copy full SHA for 324eeb3 - Browse repository at this point
Copy the full SHA 324eeb3View commit details
Commits on Jun 30, 2024
-
fix(tx_graph)!: Change tx_last_seen to
Option<u64>
Also fixup `test_list_owned_txouts` to check that the right outputs, utxos, and balance are returned at different local chain heights. This fixes an issue where unbroadcast and otherwise non-canonical transactions were returned from methods `list_chain_txs` and `Wallet::transactions` because every tx inserted had a last_seen of 0 making it appear unconfirmed. Note this commit changes the way `Balance` is represented due to new logic in `try_get_chain_position` that no longer considers txs with non-canonical anchors. Before this change, a tx anchored to a block that is reorged out had a permanent effect on the pending balance, and now only txs with a last_seen time or an anchor confirmed in the best chain will return a `ChainPosition`.
Configuration menu - View commit details
-
Copy full SHA for bbc19c3 - Browse repository at this point
Copy the full SHA bbc19c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36f5887 - Browse repository at this point
Copy the full SHA 36f5887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce4bb4 - Browse repository at this point
Copy the full SHA 2ce4bb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b34790c - Browse repository at this point
Copy the full SHA b34790cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c405729 - Browse repository at this point
Copy the full SHA c405729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496601b - Browse repository at this point
Copy the full SHA 496601bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6204d2c - Browse repository at this point
Copy the full SHA 6204d2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af75817 - Browse repository at this point
Copy the full SHA af75817View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.