Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation of #1403 #1415

Closed
wants to merge 3 commits into from
Closed

Continuation of #1403 #1415

wants to merge 3 commits into from

Conversation

evanlinjin
Copy link
Member

Description

This is an update to #1403 based on comments here: #1403 (comment)

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

LagginTimes and others added 3 commits April 24, 2024 15:37
@LagginTimes
refactor(electrum): remove RelevantTxids and track txs in TxGraph
2540258 
This PR removes `RelevantTxids` from the electrum crate and tracks
transactions in a `TxGraph`. This removes the need to separately
construct a `TxGraph` after a `full_scan` or `sync`.
@evanlinjin
feat(chain): TxGraph::insert_tx reuses Arc
4aa60ce 
When we insert a transaction that is already wrapped in `Arc`, we should
reuse the `Arc`.
@evanlinjin
feat(electrum)!: evan's fixes [WIP]
1df673c
@evanlinjin evanlinjin closed this May 1, 2024
@evanlinjin
Copy link
Member Author

This is continued in #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanlinjin @LagginTimes