Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename bdk crate to bdk_wallet #1326

Merged
merged 1 commit into from
May 13, 2024
Merged

chore: rename bdk crate to bdk_wallet #1326

merged 1 commit into from
May 13, 2024

Conversation

notmandatory
Copy link
Member

Description

Fixes #1305 .

Notes to the reviewers

Once this properly builds, even before all reviews is done, I will publish it to crates.io to reserve the name.

Changelog notice

Changed

  • Renamed bdk crate to bdk_wallet.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Feb 6, 2024
@notmandatory notmandatory added the api A breaking API change label Feb 6, 2024
@notmandatory notmandatory added this to the 1.0.0-alpha milestone Feb 6, 2024
@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 5 times, most recently from 1d1959a to 2e539dc Compare February 6, 2024 15:34
@evanlinjin
Copy link
Member

Thank you for reserving the name!

Just a reminder, I don't think we should merge this until the larger PRs are in.

@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 2 times, most recently from 7d0db6a to f8305ab Compare February 6, 2024 18:04
storopoli
storopoli approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

After we merge this, we need to also check on bitcoindevkit/bitcoindevkit.org repo and a bunch of other repos 😓

oleonardolima
oleonardolima approved these changes Mar 22, 2024
View reviewed changes
crates/wallet/src/keys/mod.rs Outdated Show resolved Hide resolved
storopoli
storopoli suggested changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise I am OK with the changes.
My concerns are with respect to the presentation.
I added some points for us to think and review.

.github/workflows/nightly_docs.yml Outdated Show resolved Hide resolved
crates/wallet/README.md Outdated Show resolved Hide resolved
crates/wallet/README.md Outdated Show resolved Hide resolved
crates/wallet/tests/psbt.rs Outdated Show resolved Hide resolved
crates/wallet/tests/psbt.rs Outdated Show resolved Hide resolved
crates/wallet/tests/wallet.rs Outdated Show resolved Hide resolved
@notmandatory
Copy link
Member Author

Rebased on master.

@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 2 times, most recently from ac671d2 to 28f6855 Compare March 24, 2024 20:30
storopoli
storopoli approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 28f6855

@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 2 times, most recently from 0993d22 to 30854de Compare April 24, 2024 00:20
@notmandatory
Copy link
Member Author

notmandatory commented Apr 24, 2024 •
edited
Loading

Rebased again on master.

storopoli
storopoli approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 30854de

ValuedMammal
ValuedMammal reviewed Apr 24, 2024
View reviewed changes
crates/wallet/Cargo.toml Show resolved Hide resolved
crates/wallet/src/keys/mod.rs Outdated Show resolved Hide resolved
@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 2 times, most recently from c82d6fc to 99acf17 Compare April 25, 2024 02:07
@notmandatory notmandatory mentioned this pull request Apr 25, 2024
Merged
@notmandatory
Copy link
Member Author

Rebased after alpha.11 release and ready to go.

storopoli
storopoli approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51cbd74

ValuedMammal
ValuedMammal approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51cbd74

@notmandatory notmandatory mentioned this pull request May 13, 2024
Closed
@notmandatory notmandatory force-pushed the chore/bdk_wallet branch 3 times, most recently from 217a942 to 7a8af0a Compare May 13, 2024 16:51
@notmandatory
Copy link
Member Author

Oops, I had to fix a couple post merge fixes and formatting and hadn't pushed them, pushed them now.

storopoli
storopoli approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a8af0a

@notmandatory notmandatory merged commit 7607b49 into bitcoindevkit:master May 13, 2024
12 checks passed
@notmandatory
Copy link
Member Author

Also published new crate: https://crates.io/crates/bdk_wallet

@notmandatory notmandatory mentioned this pull request May 23, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

@storopoli storopoli storopoli approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@notmandatory notmandatory

Labels
api A breaking API change module-wallet
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging this pull request may close these issues.

Rename bdk crate to bdk_wallet
5 participants
@notmandatory @evanlinjin @oleonardolima @storopoli @ValuedMammal