feat(esplora): include previous TxOuts for fee calculation
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LagginTimes
force-pushed
the
floating_txout
branch
from
9273bc4 to
6e7075a
Compare
evanlinjin
requested changes
Jan 31, 2024
LagginTimes
force-pushed
the
floating_txout
branch
from
6e7075a to
29c762e
Compare
evanlinjin
reviewed
Feb 2, 2024
LagginTimes
force-pushed
the
floating_txout
branch
from
29c762e to
38c383c
Compare
LagginTimes
force-pushed
the
floating_txout
branch
from
38c383c to
56473b4
Compare
evanlinjin
reviewed
Feb 4, 2024
LagginTimes
force-pushed
the
floating_txout
branch
from
56473b4 to
4990595
Compare
evanlinjin
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
ACK 4990595
Although I do not like the use of .for_each (as mentioned in #1308 (comment)), I also do not think it should be a blocker.
LagginTimes
force-pushed
the
floating_txout
branch
2 times, most recently
from
359735a to
197d0c6
Compare
The previous `TxOut` for transactions received from an external wallet are added as floating `TxOut`s to `TxGraph` to allow for fee calculation.
LagginTimes
force-pushed
the
floating_txout
branch
from
197d0c6 to
552f11c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially implements #1265.
The previous
TxOutfor transactions received from an external wallet are added as floatingTxOuts toTxGraphto allow for fee calculation.Notes to the reviewers
Currently only the
esploraportion of #1265 has been implemented.The
electrumportion will potentially be done in a new PR, as discussed on the 1/30/24 Lib call.Checklists
To Do:
electrumportion of Option for Electrum and Esplora APIs to include floatingTxOuts in updates for fee calculation #1265.All Submissions:
cargo fmtandcargo clippybefore committingNew Features: