Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc, example(bdk): fix derivation path in mnemonic_to_descriptors #1286

Conversation

ValuedMammal
Copy link
Contributor

This will help avoid confusion with mainnet descriptors.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

This will help avoid confusion with mainnet descriptors.
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d494f63

A note for the future: I didn't immediately understand why you were doing this change, I had to search BIP86 and then BIP44 only to find out that the coin_type was wrong. It would be better if the PR description or the commit message included a short explanation of what was wrong and how the commit is fixing it. Something like:

doc, example(bdk): fix derivation path in mnemonic_to_descriptors

We were using a mainnet derivation path (coin_type = 0) in a testnet example. This commit changes the coin_type to be 1 (= Bitcoin Testnet, as defined in BIP44).

(^ The wording of this commit message can be improved haha, it's just an example)

Thanks for your contribution!

@danielabrozzoni danielabrozzoni merged commit d1ea0ef into bitcoindevkit:master Jan 18, 2024
12 checks passed
@ValuedMammal ValuedMammal deleted the example/mnemonic-descriptors branch January 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants