ci: replace toolchain #1156
Closed
ci: replace toolchain #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realeinherjar
commented
Oct 8, 2023
| @@ -12,19 +12,17 @@ jobs: | |||
| rust: | |||
| - version: stable | |||
| clippy: true | |||
| - version: 1.57.0 # MSRV | |||
| - version: "1.57.0" # MSRV | |||
There was a problem hiding this comment.
Yaml is complicated, things like 1.60.0 will be rounded to 1.6.
As a best practice use strings.
Also check YAML Hell
realeinherjar
commented
Oct 8, 2023
Comment on lines
+120
to
122
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| # we pin clippy instead of using "stable" so that our CI doesn't break | ||
| # at each new cargo release | ||
| toolchain: "1.67.0" |
There was a problem hiding this comment.
Suggested change
| - uses: dtolnay/rust-toolchain@stable | |
| with: | |
| # we pin clippy instead of using "stable" so that our CI doesn't break | |
| # at each new cargo release | |
| toolchain: "1.67.0" | |
| # we pin clippy instead of using "stable" so that our CI doesn't break | |
| # at each new cargo release | |
| - uses: dtolnay/[email protected] |
This could be simplified to this if desired
realeinherjar
force-pushed
the
einherjar/rust-toolchain
branch
from
34f8a5f to
12e15f5
Compare
|
ConceptACK |
33 tasks
38 tasks
|
If the team is generally on board with switching CI to a Nix with #1165 do we still need this PR? |
|
No, this is supersed by #1165. |
54 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces
actions-rs/toolchainfordtolnay/rust-toolchainin all CI runs.Notes to the reviewers
Following the discussion in rust-bitcoin/rust-bitcoin#2113,
actions-rs/toolchainis an "Unofficial GitHub Actions for Rust programming language" which has only one person in the organization, @svartalf, which appears to be MIA for a long time.People are asking in vain for these fixes, check actions-rs/toolchain#221 (almost a year long).
There are a bunch of warnings in CI, e.g. https://github.com/bitcoindevkit/bdk/actions/runs/6443147276/job/17499339102#step:6:71.
dtolnay/rust-toolchainis by a well-established Rust developer, and it is well-maintaned (and has more stars thanactions-rs/toolchain.Also
rust-bitcoinalready replacedactions-rs/toolchainwithdtolnay/rust-toolchainin most every placeChangelog notice
Replaced
actions-rs/toolchainwithdtolnay/rust-toolchainin CI.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing