ci: Pin time, cc in order to keep MSRV #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I understand having to pin time since a new version came out a few days ago, but not sure why cc broke. But I did confirm without pinning cc the tests fail.
ACK ea6411c
danielabrozzoni
added a commit
to danielabrozzoni/bdk
that referenced
this pull request
Sep 29, 2023
Should have been in bitcoindevkit#1135, sorry.
3 tasks
notmandatory
added a commit
that referenced
this pull request
Oct 3, 2023
f28e665 ci: update code_coverage workflow to use rust stable version (Steve Myers) edfd4c2 fix: Add the pinning of time/cc in README (Daniela Brozzoni) Pull request description: Should have been in #1135, sorry. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK f28e665 Tree-SHA512: e1c2c05f436da1fd59b9988628318c0563b2dbe85a5f4fb8aef4c35d7601c441a542e8a2c3591c02f3a05ad9456cfc2d3f5e8605064498a56a39766f5bcbc2e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing