Add RPC Wallet Example #1106
Closed
Add RPC Wallet Example #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove `ElectrumUpdate` and return tuples instead for `ElectrumExt` methods. We introduce the `IncompleteTxGraph` structure to specifically hodl the incomplete `TxGraph`. This change is motivated by @LLFourn's comment: bitcoindevkit@794bf37#r1305432603
Co-authored-by: Steve Myers <[email protected]>
Also introduce `bitcoind_rpc` cli example. Add tests: * `test_sync_local_chain` ensures that `Emitter::emit_block` emits blocks in order, even after reorg. * `test_into_tx_graph` ensures that `into_tx_graph` behaves appropriately for both mempool and block updates. It should also filter txs and map anchors correctly.
Replaced `into_tx_graph_update` with `indexed_tx_graph_update`. The latter returns a vec of `(tx, anchors, last_seen)` to be passed into `IndexedTxGraph::insert_relevant_txs`.
vladimirfomene
force-pushed
the
add_rpc_wallet
branch
2 times, most recently
from
8e89e13 to
f8f3ad2
Compare
vladimirfomene
force-pushed
the
add_rpc_wallet
branch
from
f8f3ad2 to
7120eaf
Compare
41 tasks
40 tasks
|
Better if it goes in alpha.2 together with #1041, but in case we can move it to alpha.3 |
|
I'm moving this to alpha.3 since #1041 already has a non-wallet example and this one will be easier to do once that's merged. |
39 tasks
5 tasks
8 tasks
|
@vladimirfomene if you this it's still relevant, go ahead and copy/paste in the README from #1019 after you rebase this PR. |
|
Replaced by #1172 |
notmandatory
modified the milestones:
1.0.0-alpha.3,
1.0.0-alpha.4,
0.29.1,
1.0.0-beta.0
|
Moved this to beta release so we can focus final alpha releases on functional changes, leaving additional test/example/doc changes to beta milestone. |
|
Closing since it's replaced by #1172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a demonstration of how to create a wallet with a RPC syncing mechanism. This builds on #1041.
Notes to the reviewers
Will love to hear your feedback on this current implementation.
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: