Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of the coin type in the testnet wallet example descriptors #1076

Closed
wants to merge 8 commits into from
Closed

Correction of the coin type in the testnet wallet example descriptors #1076

wants to merge 8 commits into from

Conversation

casey-bowman
Copy link
Contributor

Description

Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.

@danielabrozzoni
Copy link
Member

This looks good to me, thanks! Can you please squash your commits in a single one (or drop the first 5 commits altogether), and use conventional commits for the commit message?

@notmandatory
Copy link
Member

notmandatory commented Aug 16, 2023 •
edited
Loading

We're not using the release/1.0.0-alpha branch so this PR needs to be merged to the master branch and you'll need to rebase on top of the master branch to pickup the latest commits.

@notmandatory notmandatory changed the base branch from release/1.0.0-alpha to master August 16, 2023 18:43
@casey-bowman
Copy link
Contributor Author

This looks good to me, thanks! Can you please squash your commits in a single one (or drop the first 5 commits altogether), and use conventional commits for the commit message?

I'll work on getting this squashed and rebased on master, after some other work I need to do, and switch to using the conventional commits spec, too.

Thanks for all your work on BDK! It's been great working with it so far.

@casey-bowman casey-bowman mentioned this pull request Aug 21, 2023
Merged
@nondiremanuel nondiremanuel mentioned this pull request Aug 22, 2023
Closed
30 tasks
danielabrozzoni added a commit that referenced this pull request Aug 25, 2023
@danielabrozzoni
Merge #1089: fix: Correct the coin type in the derivation path for wa…
8f978f8 
…llet examples

21206fe fix: Correct the coin type in the derivation path for the three wallet examples (Casey Bowman)

Pull request description:

  Corrects the derivation path for the three wallet examples. For testnet, the coin type should be 1 instead of 0.

  Replaces #1076

ACKs for top commit:
  danielabrozzoni:
    ACK 21206fe

Tree-SHA512: c323d90f16f338a1a678e28aa681b28848d8c5f02fd769dbf165d3a13df7804abed14760cf0dbe2be6194b107b25980b54be4703f36a7db63f6484c244dd3728
@casey-bowman
Copy link
Contributor Author

Closed, superseded by PR #1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
BDK
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casey-bowman @danielabrozzoni @notmandatory