Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: bump version to 0.28.2, downgrade esplora-client to 0.4 #1074

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 9, 2023

release: bump version to 0.28.2, downgrade esplora-client to 0.4

Also fixes new MSRV 1.57.0 issues with the tokio and cc dependencies.

closed #1073

@notmandatory notmandatory changed the base branch from master to release/0.28 August 9, 2023 17:05
@notmandatory
Copy link
Member Author

Can do this with a 0.28.2 release, need to make a 0.29.0 release that is the same as 0.28.1.

@notmandatory notmandatory reopened this Aug 9, 2023
@notmandatory
Copy link
Member Author

Figured out the MSRV issues and decided to go back to releasing a 0.28.2 version.

@notmandatory notmandatory reopened this Aug 9, 2023
@notmandatory notmandatory self-assigned this Aug 9, 2023
@notmandatory notmandatory added the release Release related issue or PR label Aug 9, 2023
@notmandatory
Copy link
Member Author

@tnull after this PR goes in it should fix your issue after a cargo update or you can set your dep to:

bdk = "0.28.2"

@notmandatory notmandatory mentioned this pull request Aug 9, 2023
3 tasks
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -223,4 +223,8 @@ cargo update -p zip --precise "0.6.3"
cargo update -p base64ct --precise "1.5.3"
# rustix 0.38.0 has MSRV 1.65.0
cargo update -p rustix --precise "0.37.23"
# tokio 0.30.0 has MSRV 1.63.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Probably 1.30.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! published before I saw this. Will fix in 0.29 release. :-)

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0ba6bbe.

CHANGELOG.md Show resolved Hide resolved
@notmandatory notmandatory merged commit 0ba6bbe into bitcoindevkit:release/0.28 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release related issue or PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants