Backport new taproot descriptor template (BIP86) #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR solves bitcoindevkit#836. This PR adds a P2TR descriptor template and a BIP86 taproot descriptor template. With this, users can now create a taproot descriptor with templates.
notmandatory
changed the title
notmandatory
force-pushed
the
feat/add-bip-86-template
branch
from
a208d38 to
7587f16
Compare
notmandatory
changed the title
19 tasks
danielabrozzoni
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
utACK 7587f16
@vladimirfomene just a heads up, you should explicitly write "ACK <commit_hash>" when reviewing, not just LGTM/approving etc. The reason for this is that we use this script to merge, which records in the merge commit who acked/nacked (see, for example, 8f38e96), and it's important to have all the reviewers and their explicit review in the merge commit (we should rely on git for recording certain info, and not on github)
This was referenced Aug 2, 2023
Closed
notmandatory
added a commit
to notmandatory/bdk
that referenced
this pull request
Aug 3, 2023
Summary This patch release backports (from the BDK 1.0 dev branch) a fix for a bug in the policy condition calculation and adds a new taproot single key descriptor template (BIP-86). The policy condition calculation bug can cause issues when a policy subtree fails due to missing info even if it's not selected when creating a new transaction, errors on unused policy paths are now ignored. Fixed - Backported bitcoindevkit#932 fix for policy condition calculation bitcoindevkit#1008 Added - Backported bitcoindevkit#840 taproot descriptor template (BIP-86) bitcoindevkit#1033
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves #836 for the release/0.28 branch. This PR adds a P2TR descriptor template and a BIP86 taproot descriptor template. With this, users can now create a taproot descriptor with templates.
Notes to the reviewers
The commit from #840 is cherry-picked from the
masterbranch to therelease/0.28branch without any changes.Changelog notice
Add taproot descriptor template (BIP-86).
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: