remove duplicate is_empty
#1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirfomene
force-pushed
the
remove-duplicate-is_empty
branch
2 times, most recently
from
1bf784c to
c844416
Compare
vladimirfomene
force-pushed
the
remove-duplicate-is_empty
branch
from
c844416 to
f5074ee
Compare
| @@ -72,6 +67,7 @@ impl<K: Ord> Append for DerivationAdditions<K> { | |||
| self.0.append(&mut other.0); | |||
| } | |||
|
|
|||
| /// Returns whether the additions are empty. | |||
| fn is_empty(&self) -> bool { | |||
There was a problem hiding this comment.
The other one was pub, this one is not
There was a problem hiding this comment.
I saw that but also saw that the Append trait is public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate
is_emptymethodChecklists
All Submissions:
cargo fmtandcargo clippybefore committing