Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge or backport "Fix policy condition calculation" #942

Closed
notmandatory opened this issue Apr 17, 2023 · 1 comment
Closed

Merge or backport "Fix policy condition calculation" #942

notmandatory opened this issue Apr 17, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
0.28.1

Comments

@notmandatory
Copy link
Member

Describe the bug

See fix #932, it should be merged or backported to the release/0.28 branch. This issue is a reminder that it needs to be done.
@notmandatory notmandatory added the bug Something isn't working label Apr 17, 2023
@notmandatory notmandatory changed the title Merge or backport "Fix policy condition calculation" to release/0.28 branch Merge or backport "Fix policy condition calculation" Apr 17, 2023
@notmandatory notmandatory moved this to Todo in BDK Maintenance Apr 17, 2023
@notmandatory notmandatory added this to the 0.28.1 milestone Apr 17, 2023
@junderw junderw mentioned this issue Jun 16, 2023
Merged
3 tasks
notmandatory added a commit that referenced this issue Jun 26, 2023
@notmandatory
Merge #1008: Backporting "Fix policy condition calculation" onto rele…
6097957 
…ase/0.28

9cffaad Fix build errors (junderw)
3ccdb84 Fix policy condition calculation When constructing the `Condition` struct we recursively call `get_condition` on all the items in a threshold and short-circuit if there's an error somewhere (for example, because the policy-path hasn't been provided for a specific threshold). (Alekos Filini)

Pull request description:

  Fixes #942

  ### Description

  This backports "Fix policy condition calculation" (#932) onto release/0.28

  ### Notes to the reviewers

  Currently kept the Author the same and the committer is myself. Let me know if this is not the desired outcome of the history. (I have made no modifications myself)

  ### Changelog notice

  Backported "Fix policy condition calculation"

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 9cffaad

Tree-SHA512: c505bc9c8efd75cfa23db7a0e77f010f1758a1b6725661a1af1bcb40c6fd606a13e50ca005c7752fe28c3b7cd748c182fdb5870693e299adaf230adeef02517a
@notmandatory
Copy link
Member Author

fixed by #1008

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Maintenance Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
BDK Maintenance
Archived in project
Milestone
0.28.1
Development

No branches or pull requests
1 participant
@notmandatory