Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxGraph::direct_conflicts_of_tx should just be called direct_conflicts #1138

Closed
danielabrozzoni opened this issue Sep 29, 2023 · 2 comments · Fixed by #1164
Closed

TxGraph::direct_conflicts_of_tx should just be called direct_conflicts #1138

danielabrozzoni opened this issue Sep 29, 2023 · 2 comments · Fixed by #1164
Labels
good first issue Good for newcomers
Milestone
1.0.0-alpha.2

Comments

@danielabrozzoni
Copy link
Member

See #1064 (comment)
@danielabrozzoni danielabrozzoni added the good first issue Good for newcomers label Sep 29, 2023
@danielabrozzoni danielabrozzoni mentioned this issue Sep 29, 2023
Merged
5 tasks
@rustaceanrob
Copy link
Contributor

Before I submit a PR this is just a rename of TxGraph::direct_conflicts_of_tx to TxGraph::direct_conflicts?

@danielabrozzoni danielabrozzoni changed the title TxGraph::direct_conflicts_of_tx should just be called direct_conflicts` TxGraph::direct_conflicts_of_tx should just be called direct_conflicts Oct 3, 2023
@danielabrozzoni
Copy link
Member Author

Before I submit a PR this is just a rename of TxGraph::direct_conflicts_of_tx to TxGraph::direct_conflicts?

Yes, but please either build your PR on top of #1064 or wait for it to be merged before working on this :)

@danielabrozzoni danielabrozzoni moved this to Todo in BDK Oct 3, 2023
@nondiremanuel nondiremanuel mentioned this issue Oct 6, 2023
Closed
39 tasks
@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.2 milestone Oct 10, 2023
danielabrozzoni added a commit to danielabrozzoni/bdk that referenced this issue Oct 10, 2023
@danielabrozzoni
ref(chain): Rename direct_conflicts_of_tx to...
dee2f57 
...direct_conflitcs

Fixes bitcoindevkit#1138
@danielabrozzoni danielabrozzoni mentioned this issue Oct 10, 2023
Merged
3 tasks
danielabrozzoni added a commit that referenced this issue Oct 10, 2023
@danielabrozzoni
Merge #1164: ref(chain): Rename direct_conflicts_of_tx to direct_conf…
6ebdd19 
…litcs

d5c87c4 ref(chain): Rename direct_conflicts_of_tx to... ...direct_conflitcs (Daniela Brozzoni)
009408d ci: Pin jobserver to 0.1.26 to keep MSRV (Daniela Brozzoni)

Pull request description:

  Fixes #1138

  ### Changelog notice

  - rename `TxGraph::direct_conflicts_of_tx` to `TxGraph::direct_conflicts`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK d5c87c4

Tree-SHA512: 10072c65025d5fcc5d90c61ecba1dad53bcd10929326ab18ddadb21322841203aa5861adc9c5f200bbc57b0fe59dd4859dc3672870a0ad343fd8a660fd8aa40e
@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

ref(chain): Rename direct_conflicts_of_tx to direct_conflitcs danielabrozzoni/bdk
3 participants
@danielabrozzoni @nondiremanuel @rustaceanrob