Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log dependency fix makes use as library very hard #1035

Closed
stevenroose opened this issue Jul 19, 2023 · 3 comments · Fixed by #1046
Closed

Log dependency fix makes use as library very hard #1035

stevenroose opened this issue Jul 19, 2023 · 3 comments · Fixed by #1046
Assignees
@danielabrozzoni
Labels
bug Something isn't working
Milestone
1.0.0-alpha.2

Comments

@stevenroose
Copy link
Contributor

bdk depends on log = "=0.4.18", which is really annoying for anyone having another version of log in their dependency tree.
@stevenroose stevenroose added the bug Something isn't working label Jul 19, 2023
@LLFourn
Copy link
Contributor

LLFourn commented Jul 20, 2023

Looks like this was done in #1009. I think the correct solution is to just pin the version in CI using a CI specific Cargo.lock?

On a side note I'd be in favor of not using log throughout the codebase as I don't find it very helpful as an app developer but maybe that's just me.

@tnull
Copy link
Contributor

tnull commented Jul 20, 2023

Looks like this was done in #1009. I think the correct solution is to just pin the version in CI using a CI specific Cargo.lock?

I think other project (LDK, rust-bitcoin) just have a msrv flag in CI and pin the respective dependencies based on it, i.e., we just run this in CI:

	[ "$RUSTC_MINOR_VERSION" -lt 49 ] && cargo update -p log --precise "0.4.18" --verbose

(see https://github.com/lightningdevkit/rust-lightning/blob/8a8f29a8bb970ef99137db7233ca85e1a2406b7a/ci/ci-tests.sh#L16)

danielabrozzoni added a commit to danielabrozzoni/bdk that referenced this issue Jul 24, 2023
@danielabrozzoni
Avoid pinning dependencies, use --precise in ci
2f9b7c5 
Fixes bitcoindevkit#1035
@danielabrozzoni danielabrozzoni mentioned this issue Jul 24, 2023
Merged
3 tasks
danielabrozzoni added a commit to danielabrozzoni/bdk that referenced this issue Jul 24, 2023
@danielabrozzoni
Avoid pinning dependencies, use --precise in ci
785ff8a 
Fixes bitcoindevkit#1035
danielabrozzoni added a commit to danielabrozzoni/bdk that referenced this issue Jul 24, 2023
@danielabrozzoni
Avoid pinning dependencies, use --precise in ci
8c7ed11 
Fixes bitcoindevkit#1035
@danielabrozzoni
Copy link
Member

danielabrozzoni commented Jul 24, 2023 •
edited
Loading

Sorry, when I pinned log I didn't realize it could be an issue for downstream projects. #1046 should fix :)

danielabrozzoni added a commit to danielabrozzoni/bdk that referenced this issue Jul 25, 2023
@danielabrozzoni
Avoid pinning dependencies, use --precise in ci
16f4ef3 
Fixes bitcoindevkit#1035
danielabrozzoni added a commit that referenced this issue Jul 25, 2023
@danielabrozzoni
Merge #1046: Avoid pinning dependencies, use --precise in ci
8f38e96 
ffb7c79 ci: Avoid pinning dependencies, use --precise (Daniela Brozzoni)
56b8eea ci: No need to add the llvm repository for wasm (Daniela Brozzoni)

Pull request description:

  Fixes #1035

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK ffb7c79

Tree-SHA512: a2e5e0ffea87dc86e27c2f2f3550e6e6429e66f5fd8e0196e85915de5b0f14f0e4ee9d56c87b38b101eb28d86a65868054c20421f32ecd475ca73d00471e2f8d
@notmandatory notmandatory added this to BDK Jul 25, 2023
@notmandatory notmandatory moved this to Done in BDK Jul 25, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielabrozzoni danielabrozzoni

Labels
bug Something isn't working
Projects
BDK
Archived in project
Milestone
1.0.0-alpha.2
Development

Successfully merging a pull request may close this issue.

Avoid pinning dependencies, use --precise in ci danielabrozzoni/bdk
5 participants
@tnull @stevenroose @LLFourn @notmandatory @danielabrozzoni