-
Notifications
You must be signed in to change notification settings - Fork 322
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #1267: Simplify
Esplora::update_local_chain
and add tests
c5afbaa ci: update zstd-sys version to work with MSRV 1.63 (Steve Myers) 929b5dd refactor(esplora): better variable naming and docs (志宇) 216648b chore(esplora): Clarify consistency guarantees (LLFourn) 63fa710 fix(esplora): reuse returned height instead of zipping (志宇) 6f824cf test(esplora): introduce test cases for `update_local_chain` (志宇) f05e850 feat(esplora): greatly simplify `update_local_chain` (志宇) Pull request description: Fixes #1199 ### Description After a second look at the `update_local_chain` implementations, it was clear that they were over complicated. This PR simplifies the `EsploraExt::update_local_chain` method(s) of the `bdk_esplora` crate and adds a whole bunch of tests. ### Notes to the reviewers The description of #1199 is very brief, however @danielabrozzoni mentioned about potentially-problematic logic with `ASSUME_FINAL_DEPTH`. The logic was indeed convoluted and it did not need to be that way. This PR removes the need for `ASSUME_FINAL_DEPTH`. ### Changelog notice Fixed - Simplified `EsploraExt::update_local_chain` logic. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: ~* [ ] This pull request breaks the existing API~ ~* [ ] I've added tests to reproduce the issue which are now passing~ (there are now lots of tests though) * [x] I'm linking the issue being fixed by this PR ACKs for top commit: evanlinjin: ACK c5afbaa notmandatory: utACK c5afbaa Tree-SHA512: f588493a4643f0f68d3181f27adf91793d4e336be6e853a26289e0916ed83169e1067260b75e627f190842f691ec095e668c0b799ca80e7da2849dd28de32754
- Loading branch information
Showing
5 changed files
with
297 additions
and
168 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.