Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): used owned transaction #46

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

rustaceanrob
Copy link
Collaborator

it feels like if a user is broadcasting a transaction, they are likely done with it. if they still need the transaction after broadcast, i feel like that clone should be moved to the callsite? @ValuedMammal

@ValuedMammal
Copy link
Collaborator

Yes it would also communicate better that kyoto needs an owned value in order to create a network message

@rustaceanrob rustaceanrob merged commit 45ec5a5 into bitcoindevkit:master Sep 10, 2024
@rustaceanrob rustaceanrob deleted the owned-tx-09-09 branch September 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants