Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Update to bdk-ffi 0.6.0 (remove Blockchain from Wallet) #54

Merged
merged 3 commits into from
May 16, 2022

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Apr 22, 2022

Description

Major API changes from bdk-ffi 0.5.0 -> 0.6.0:

  • new Blockchain class constructed from BlockchainConfig
  • Wallet sync method requires a Blockchain and optional Progress callback
  • Blockchain broadcast method returns no txid value
  • new PartiallySignedBitcoinTransaction method to get txid
  • TxBuilder.build renamed to TxBuilder.finish to match rust bdk API

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added this to the Release 0.6.0 milestone Apr 22, 2022
@notmandatory notmandatory self-assigned this Apr 22, 2022
@notmandatory notmandatory changed the title Update to bdk-ffi 0.6.0 Update to bdk-ffi 0.6.0 (remove Blockchain from Wallet) Apr 22, 2022
@notmandatory notmandatory marked this pull request as ready for review April 26, 2022 00:43
@notmandatory notmandatory marked this pull request as draft April 26, 2022 04:04
@notmandatory
Copy link
Member Author

This will be ready to review once bitcoindevkit/bdk-ffi#149 is merged and bdk-ffi release 0.6.0 is tagged.

@notmandatory notmandatory marked this pull request as ready for review May 12, 2022 22:44
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK cecf973.

@notmandatory notmandatory merged commit cecf973 into bitcoindevkit:master May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants