Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uniffi-rs to 0.19.3 #173

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

thunderbiscuit
Copy link
Member

This PR brings bdk-ffi on the latest version of uniffi-rs.

[dependencies]
anyhow = "=1.0.45" # remove after upgrading to next version of uniffi
structopt = "0.3"
uniffi_bindgen = "0.16.0"
uniffi_bindgen = "0.19.3"
camino = "1.0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway to do this update without adding a new dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind camino doesn't have any more dependencies on it and this is only for the bdk-ffi-bindgen so I think it's OK.

@thunderbiscuit
Copy link
Member Author

This is currently failing because somehow the bindgen tool is trying to create the src/bdk.udl file rather than simply using it?

Input UDL file is "src/bdk.udl"
Chosen language is kotlin
Output directory is "./"
Error: failed to create directory `src/bdk.udl`

Caused by:
    File exists (os error 17)

@thunderbiscuit
Copy link
Member Author

thunderbiscuit commented Jul 25, 2022

My bad. I had changed the arguments we were giving to the uniffi_bindgen::generate_bindings() method.

Fixed.

I tested with bdk-kotlin and bdk-kotlin-test-suite and everything runs fine.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ee737af

@notmandatory notmandatory added this to the Release 0.8.0 milestone Jul 25, 2022
@thunderbiscuit thunderbiscuit merged commit fa5c67c into bitcoindevkit:master Jul 25, 2022
@thunderbiscuit thunderbiscuit deleted the bump-uniffirs branch November 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants