Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.0.1 final changes #26647

Merged
merged 3 commits into from
Dec 6, 2022
Merged

24.0.1 final changes #26647

merged 3 commits into from
Dec 6, 2022

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Dec 6, 2022

Changes for 24.0.1.

At this stage, I don't think an rc is necessary here, and would just add another 5-x days delay to fixing these issues.

This will be accompanied by a pull request to master to add a note in the 24.0.md that already exists there. Similar to what was done with 0.19.0.1.

@fanquake fanquake added this to the 24.0.1 milestone Dec 6, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 6, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, josibake, gruve-p, instagibbs, w0xlt

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto
hebasto approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9ea715, I have reviewed the changes and they look OK.

josibake
josibake approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@josibake josibake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9ea715

lgtm, altho im assuming its okay to modify doc/man files because they are generated one time as part of creating the 24.x branch

@gruve-p
Copy link
Contributor

gruve-p commented Dec 6, 2022

ACK a9ea715

1 similar comment
@instagibbs
Copy link
Member

ACK a9ea715

w0xlt
w0xlt approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9ea715

@maflcko maflcko merged commit b3f866a into bitcoin:24.x Dec 6, 2022
@fanquake fanquake deleted the 24_0_1_final_changes branch December 6, 2022 16:05
@bitcoin bitcoin deleted a comment from superioreturns Jan 28, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josibake josibake josibake approved these changes

@hebasto hebasto hebasto approved these changes

@w0xlt w0xlt w0xlt approved these changes

Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
24.0.1
Development

Successfully merging this pull request may close these issues.
8 participants
@fanquake @DrahtBot @gruve-p @instagibbs @josibake @hebasto @w0xlt @maflcko