Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci, doc: Travis CI features and mentions cleanup #20691

Merged
merged 2 commits into from
Dec 18, 2020
Merged

ci, doc: Travis CI features and mentions cleanup #20691

merged 2 commits into from
Dec 18, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Dec 17, 2020

As Travis CI is no longer used, this PR:

  • drops travis_fold feature
  • drops mentions of Travis CI in docs

@hebasto hebasto mentioned this pull request Dec 17, 2020
Closed
maflcko
maflcko reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to just say CI, which can't be wrong

doc/release-process.md Outdated
@@ -307,9 +307,9 @@ bitcoin.org (see below for bitcoin.org update instructions).
- First, check to see if the Bitcoin.org maintainers have prepared a
release: https://github.com/bitcoin-dot-org/bitcoin.org/labels/Core

- If they have, it will have previously failed their Travis CI
- If they have, it will have previously failed their Cirrus CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitcoin(core).org is still using Travis

Suggested change
- If they have, it will have previously failed their Cirrus CI
- If they have, it will have previously failed their CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

test/functional/README.md Outdated
@@ -23,7 +23,7 @@ don't have test cases for.
- The oldest supported Python version is specified in [doc/dependencies.md](/doc/dependencies.md).
Consider using [pyenv](https://github.com/pyenv/pyenv), which checks [.python-version](/.python-version),
to prevent accidentally introducing modern syntax from an unsupported Python version.
The Travis linter also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
The Cirrus CI linter job also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to be overly specific

Suggested change
The Cirrus CI linter job also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).
The CI linter job also checks this, but [possibly not in all cases](https://github.com/bitcoin/bitcoin/pull/14884#discussion_r239585126).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

jonatack
jonatack reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. I think you can just say CI instead of Cirrus CI everywhere you change here for less churn and maintenance. People see the CI sources in the PRs anyway. Maybe in one or two of the more official places you could optionally write CI (Continuous Integration) instead of just CI.

doc/developer-notes.md Outdated
@@ -543,7 +543,7 @@ General Bitcoin Core
- *Rationale*: RPC allows for better automatic testing. The test suite for
the GUI is very limited.

- Make sure pull requests pass Travis CI before merging.
- Make sure pull requests pass Cirrus CI before merging.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Make sure pull requests pass Cirrus CI before merging.
- Make sure pull requests pass CI before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@hebasto
Copy link
Member Author

hebasto commented Dec 17, 2020

Updated 4f286f8 -> 95487b0 (pr20691.01 -> pr20691.02, diff):

@maflcko
Copy link
Member

maflcko commented Dec 18, 2020

ACK 95487b0

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko merged commit 9b28bd7 into bitcoin:master Dec 18, 2020
@DrahtBot DrahtBot mentioned this pull request Dec 18, 2020
Merged
@hebasto hebasto deleted the 201217-travis branch December 18, 2020 08:06
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 18, 2020
Merge bitcoin#20691: ci, doc: Travis CI features and mentions cleanup
0d39448
@bitcoin bitcoin locked and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maflcko maflcko maflcko left review comments

@jonatack jonatack jonatack left review comments

Assignees
No one assigned
Labels
Docs Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @maflcko @DrahtBot @jonatack