Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adjust cirrus ci task names #20545

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 2, 2020

The task names are too long for GitHub to display them properly without truncation in the "checks-view". Fix that by using a new naming scheme:

  • Native builds don't mention "x86_64 Linux", as it is redundant, they do mention the OS (bionic or focal) in the name suffix
  • Cross builds mention the target in the prefix and the OS (always bionic) in the suffix
  • the macos native build simply says "macos native"

@practicalswift
Copy link
Contributor

ACK fa770e9

Thanks for tidying up!

Are the double spaces between brackets a hommage to the world-famous double spacer and Sourceforge user s_nakamoto? :)

@maflcko
Copy link
Member Author

maflcko commented Dec 2, 2020

remove double spaces, as they are not displayed in a browser anyway

@practicalswift
Copy link
Contributor

ACK fa5c4f1: patch  looks  correct!

@DrahtBot DrahtBot added the Tests label Dec 2, 2020
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa5c4f1, I have reviewed the code and it looks OK, I agree it can be merged.

It was in my todo list too :)

@fanquake
Copy link
Member

fanquake commented Dec 2, 2020

Concept ACK - thanks

Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa5c4f1

@maflcko maflcko merged commit a35b948 into bitcoin:master Dec 2, 2020
@maflcko maflcko deleted the 2012-ciNames branch December 2, 2020 16:29
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 2, 2020
maflcko pushed a commit that referenced this pull request Dec 5, 2020
667b6a2 ci: Adjust Cirrus CI task names (follow up) (Hennadii Stepanov)

Pull request description:

  "no depends" implies "only system libs".

  #20545 follow up .

ACKs for top commit:
  practicalswift:
    ACK 667b6a2

Tree-SHA512: b3bf5dc931b7aeed30932e8d6c5f5b0040e4be5a5676ed23b41675ebad2f8a016b1abb27584b68970ee00bc5b2af7122ca9566f373db5f3a2e38fcf7eee6522a
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 5, 2020
667b6a2 ci: Adjust Cirrus CI task names (follow up) (Hennadii Stepanov)

Pull request description:

  "no depends" implies "only system libs".

  bitcoin#20545 follow up .

ACKs for top commit:
  practicalswift:
    ACK 667b6a2

Tree-SHA512: b3bf5dc931b7aeed30932e8d6c5f5b0040e4be5a5676ed23b41675ebad2f8a016b1abb27584b68970ee00bc5b2af7122ca9566f373db5f3a2e38fcf7eee6522a
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
apoelstra pushed a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
apoelstra added a commit to apoelstra/elements that referenced this pull request Jul 11, 2021
stevenroose added a commit to ElementsProject/elements that referenced this pull request Jul 12, 2021
1e63e57 ci: disable Werror on MacOS build (not a backport) (Andrew Poelstra)
1852f83 ci: Bump macOS image to big-sur-xcode-12.5 (MarcoFalke)
4f33ba7 ci: Fix macOS brew install command (Hennadii Stepanov)
0265085 ci: Bump macOS VM image to the latest version (Hennadii Stepanov)
0740cee ci: Adjust cirrus ci task names (Andrew Poelstra)
d08e584 ci: Fix doc typos in .cirrus.yml (Andrew Poelstra)
953cbe2 ci: Run nowallet ci config on cirrus (MarcoFalke)
60a5632 build: set minimum supported macOS to 10.14 (fanquake)

Pull request description:

  Backport of bitcoin/bitcoin#20419 then bitcoin/bitcoin#19179 (except 2nd commit "Run i686 centos ci config on cirrus" which requires some more supporting PRs) then bitcoin/bitcoin#20545 then bitcoin/bitcoin#21542 then
  bitcoin/bitcoin#21663 then bitcoin/bitcoin#22122

  We are getting 403 errors in our MacOS job on Cirrus, presumably because bintray.com has shut down (see discussion on upstream PR 21663). Backport this PR and several supporting ones. These PRs will be merged as part of the 22.0 rebase. In the interest of keeping CI running let's backport them early.

Top commit has no ACKs.

Tree-SHA512: cdfe96789adedbfb617cdafb534175323a8fd46606e67adf7053f97cc32712dd3ece850906b522b6b0bed137f52c1372319f52f4a7b303aec479ea54d213271c
fanquake added a commit to bitcoin-core/gui that referenced this pull request Nov 17, 2021
fa45922 ci: Rework ci task names (MarcoFalke)

Pull request description:

  It is hard to find a specific sanitizer task in less than a second. Fix that by mentioning the sanitizer first in the task name. Less useful information (with or without depends) follows the sanitizer.

  Follow up to:

  * bitcoin/bitcoin#20545
  * bitcoin/bitcoin#20572

ACKs for top commit:
  fanquake:
    ACK fa45922

Tree-SHA512: 87165caff4749cc415cef6ae36cac63fa448cec0a1c92cd6b691a0fbd22902466c8d861b0d922c3331e4bf36dbb4eba86d745ef135f391f7ff81461fe5159e05
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 17, 2021
fa45922 ci: Rework ci task names (MarcoFalke)

Pull request description:

  It is hard to find a specific sanitizer task in less than a second. Fix that by mentioning the sanitizer first in the task name. Less useful information (with or without depends) follows the sanitizer.

  Follow up to:

  * bitcoin#20545
  * bitcoin#20572

ACKs for top commit:
  fanquake:
    ACK fa45922

Tree-SHA512: 87165caff4749cc415cef6ae36cac63fa448cec0a1c92cd6b691a0fbd22902466c8d861b0d922c3331e4bf36dbb4eba86d745ef135f391f7ff81461fe5159e05
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants