Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: Update location of seeds.txt #10495

Merged
merged 1 commit into from
Jun 1, 2017
Merged

contrib: Update location of seeds.txt #10495

merged 1 commit into from
Jun 1, 2017

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Jun 1, 2017

Update the steps for updating the hardcoded seed nodes to point to the new filename on @sipa's server, and add command to decompress it.

Ref: #10163

@laanwj laanwj added the Docs label Jun 1, 2017
@jonasschnelli
Copy link
Contributor

Tested ACK ac9df130a507177ec77ef3f5f4fa43c0c5ef57c3

practicalswift
practicalswift reviewed Jun 1, 2017
View reviewed changes
contrib/seeds/README.md Outdated
@@ -8,7 +8,7 @@ and remove old versions as necessary.

The seeds compiled into the release are created from sipa's DNS seed data, like this:

curl -s http://bitcoin.sipa.be/seeds.txt > seeds_main.txt
curl -s http://bitcoin.sipa.be/seeds.txt.gz | gunzip > seeds_main.txt
Copy link
Contributor

@practicalswift practicalswift Jun 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Isn't | gzip -dc preferred over | gunzip?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laanwj Good question! :-) Perhaps it is a legacy thing, but for some reason I have it hard wired that gzip -dc is used when operating on stdin/stdout and gunzip is for unpacking file.gz, removing the original file and leaving file. They might be totally equivalent nowadays. If so, ignore my minor nit :-)

Copy link
Contributor

@practicalswift practicalswift Jun 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this thread: https://lists.gnu.org/archive/html/bug-automake/2009-10/msg00012.html

@paveljanik
Copy link
Contributor

IIRC on some systems, gunzip symlink was not available in the default install.

@laanwj
Copy link
Member Author

laanwj commented Jun 1, 2017

IIRC on some systems, gunzip symlink was not available in the default install.

I tried on FreeBSD, OpenBSD, Linux (Ubuntu) and gunzip worked out of the box at least... Also these are not general instructions for end-users, but for ourselves. I personally find gunzip much easier to remember. But meh I'm fine with changing it.

@laanwj
contrib: Update location of seeds.txt
ac9cd95 
Update the steps for updating the hardcoded seed nodes to point to the
new filename on @sipa's server, and add command to decompress it.

Ref: bitcoin#10163
@laanwj laanwj force-pushed the 2017_06_seeds_source branch from ac9df13 to ac9cd95 Compare June 1, 2017 10:38
@fanquake
Copy link
Member

fanquake commented Jun 1, 2017

utACK ac9cd95

@practicalswift
Copy link
Contributor

ACK ac9cd95

@laanwj laanwj merged commit ac9cd95 into bitcoin:master Jun 1, 2017
laanwj added a commit that referenced this pull request Jun 1, 2017
@laanwj
Merge #10495: contrib: Update location of seeds.txt
6a38b79 
ac9cd95 contrib: Update location of seeds.txt (Wladimir J. van der Laan)

Tree-SHA512: c12a75787ba87f03707c21731da083b466762a7e0af9ca501107695ea1074025907cc24805c7c87f4a66daa7f4f13e574da16be1681e61deaf1acbd72176b3ff
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Jun 5, 2017
@laanwj @luke-jr
contrib: Update location of seeds.txt
76f9cf9 
Update the steps for updating the hardcoded seed nodes to point to the
new filename on @sipa's server, and add command to decompress it.

Ref: bitcoin#10163

Github-Pull: bitcoin#10495
Rebased-From: ac9cd95
nomnombtc pushed a commit to nomnombtc/bitcoin that referenced this pull request Jul 17, 2017
@laanwj @nomnombtc
contrib: Update location of seeds.txt
0e1fe8c 
Update the steps for updating the hardcoded seed nodes to point to the
new filename on @sipa's server, and add command to decompress it.

Ref: bitcoin#10163

Github-Pull: bitcoin#10495
Rebased-From: ac9cd95
codablock pushed a commit to codablock/dash that referenced this pull request Jan 26, 2018
@laanwj @codablock
Merge bitcoin#10495: contrib: Update location of seeds.txt
e9976d2 
ac9cd95 contrib: Update location of seeds.txt (Wladimir J. van der Laan)

Tree-SHA512: c12a75787ba87f03707c21731da083b466762a7e0af9ca501107695ea1074025907cc24805c7c87f4a66daa7f4f13e574da16be1681e61deaf1acbd72176b3ff
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#10495: contrib: Update location of seeds.txt
b806c90 
ac9cd95 contrib: Update location of seeds.txt (Wladimir J. van der Laan)

Tree-SHA512: c12a75787ba87f03707c21731da083b466762a7e0af9ca501107695ea1074025907cc24805c7c87f4a66daa7f4f13e574da16be1681e61deaf1acbd72176b3ff
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#10495: contrib: Update location of seeds.txt
dcddd69 
ac9cd95 contrib: Update location of seeds.txt (Wladimir J. van der Laan)

Tree-SHA512: c12a75787ba87f03707c21731da083b466762a7e0af9ca501107695ea1074025907cc24805c7c87f4a66daa7f4f13e574da16be1681e61deaf1acbd72176b3ff
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@practicalswift practicalswift practicalswift left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laanwj @jonasschnelli @paveljanik @fanquake @practicalswift