Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for p2sh multisig wallet structure #89

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

maraoz
Copy link
Contributor

@maraoz maraoz commented Jul 10, 2014

==Motivation==

The structure proposed in this document allows for standard ways to create,
use, import, and HDPM wallets. It allows to handle multiple parties sharing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HDPM = hierarchical deterministic P2SH multi-signature, as defined above.
Or is there another typo there? (I can't english)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"create, use, import, and HDPM wallets."

I suspect what you mean is "create, use, and import HDPM wallets.", or maybe you accidentally a word and it should be "create, use, import, and HDPM wallets."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks!

@laanwj
Copy link
Member

laanwj commented Oct 15, 2014

This seems to be stuck?

As this has been discussed on the mailing list and the response is positive, I think you should move to the next phase and request a BIP number from gmaxwell.

@maraoz
Copy link
Contributor Author

maraoz commented Oct 15, 2014

I already did, 3 times in the past 6 months. There's no rush but @gmaxwell has been unresponsive so far.

On Wed, Oct 15, 2014 at 6:16 AM, Wladimir J. van der Laan
[email protected] wrote:

This seems to be stuck?

As this has been discussed on the mailing list and the response is positive, I think you should move to the next phase and request a BIP number from gmaxwell.

Reply to this email directly or view it on GitHub:
#89 (comment)

@laanwj
Copy link
Member

laanwj commented Oct 15, 2014

It wouldn't be the first time it takes a long time - @gmaxwell is very busy, but I don't think number allocation should be a blocker in the BIP process. As I've stated in the past, I think we need more BIP editors that can deal these out to avoid this.

@gmaxwell
Copy link
Contributor

Gah. BIP 45.

@maraoz maraoz force-pushed the p2sh-multisig-wallets branch from 95e1d68 to 3d88667 Compare October 17, 2014 17:06
@maraoz
Copy link
Contributor Author

maraoz commented Oct 17, 2014

updated with assigned number

@@ -0,0 +1 @@
*.swp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add a project-wide gitignore. Gitignore is meant for temporary files that are generated during the build process. We don't have a build system for bips, so there are none.
There are various other ways in which you can see local ignore rules, see https://help.github.com/articles/ignoring-files/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining! I didn't know about local ignore rules :)

@laanwj
Copy link
Member

laanwj commented Oct 21, 2014

Don't forget to add an entry in the table in https://github.com/bitcoin/bips/blob/master/README.mediawiki

@maraoz maraoz force-pushed the p2sh-multisig-wallets branch from debfc1f to bd0da6f Compare October 21, 2014 20:38
@maraoz
Copy link
Contributor Author

maraoz commented Oct 21, 2014

updated:

  • squashed commits
  • added mailing list reference
  • fixed @laanwj suggestions
  • added more examples

laanwj added a commit that referenced this pull request Oct 22, 2014
Draft for p2sh multisig wallet structure
@laanwj laanwj merged commit 6d120e6 into bitcoin:master Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants