Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip99: Improvements #237

Merged
merged 7 commits into from
Nov 13, 2015
Merged

Bip99: Improvements #237

merged 7 commits into from
Nov 13, 2015

Conversation

jtimon
Copy link
Contributor

@jtimon jtimon commented Nov 8, 2015

Continues #181, including some things that were left out by accident.

@btcdrak
Copy link
Contributor

btcdrak commented Nov 8, 2015

Just noticed your email address is in square brackets whereas the convention is to use angle brackets <[email protected]>.

Also it is customary to put the part in the header " Post-History: http://lists.linuxfoundation.org/pipermail/bitcoin-dev/2015-June/008936.html" down in the references section of the document.

@jtimon
Copy link
Contributor Author

jtimon commented Nov 10, 2015

Corrected the email. But BIP1 says "Post-History" is an optional field in the "BIP Header Preamble", so I'll leave it there.

luke-jr added a commit that referenced this pull request Nov 13, 2015
@luke-jr luke-jr merged commit df5a119 into bitcoin:master Nov 13, 2015
luke-jr pushed a commit to luke-jr/bips that referenced this pull request Jan 20, 2018
This was changed in bitcoin#237 so fix it here as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants