Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip353: improve ₿-prefix instructions #1645

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented Jul 11, 2024

I was very confused when reading the ₿-prefix instruction for BIP353. Others have been confused as well:

This PR reorders the sentences and slightly rewords them.

Because the rationale comes after these instructions, it's important to first point out the main aim: [email protected] should be the default rendering, it's not just some optional alternative format.

I moved the bit about external (hardware) wallets down.

I'm unconvinced the ₿-prefix is a good idea in the first place, but this PR doesn't change it.

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK

bip-0353.mediawiki Outdated Show resolved Hide resolved
bip-0353.mediawiki Outdated Show resolved Hide resolved
bip-0353.mediawiki Outdated Show resolved Hide resolved
Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, ACK!

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

@jonatack jonatack merged commit ee56747 into bitcoin:master Jul 12, 2024
3 checks passed
@Sjors Sjors deleted the 2024/07/bip353 branch July 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants