Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP0039 added Spanish wordlist #100

Merged
merged 1 commit into from
Oct 17, 2014
Merged

BIP0039 added Spanish wordlist #100

merged 1 commit into from
Oct 17, 2014

Conversation

Y75QMO
Copy link
Contributor

@Y75QMO Y75QMO commented Sep 2, 2014

These are a some of the restrictions we have followed in order to create the Spanish wordlist:

  1. It is possible to uniquely identify a word just typing the first four or less characters of the word.
  2. Spanish words have special characters (such as á, é, ü, ñ, etc.) not available in every keyboard. It is possible to type 'a' instead of 'á' or 'n' instead of 'ñ', etc. while still being able to identify the word with the first 4 characteres. This means that, for example, 'caña' and 'canal' cannot be both in the wordlist.
  3. There are some combinations of letters that sound similar. There cannot be two words that only differenciate on those combinations of letters. For example, 'hola' and 'ola' cannot be both in the wordlist. 'quiosco' and 'kiosko' cannot be both in the wordlist.
  4. Only standard form of verbs (infinitive), nouns and adjetives are in the list.
  5. The more common words are preferred over less common words.
  6. Shorter, simpler, words are preferred over longer words. For example 'libro' is prefered over 'librería'

There are more restrictions. The full set of restrictions is defined in python here: https://github.com/Y75QMO/Tests-for-BIP39-Spanish-wordlist.

We have scanned using software more than 600,000 words and manually reviewed one by one more than 40,000 words. Choosing 2,048 and following all the rules is not an easy task and more than one list is possible. Any help or review of the wordlist is appreciated.

@laanwj
Copy link
Member

laanwj commented Oct 15, 2014

Paging @voisine as (one of) the authors of BIP39, can you have a look at this change?

@voisine
Copy link
Contributor

voisine commented Oct 16, 2014

non-spanish speaking ack.

@voisine
Copy link
Contributor

voisine commented Oct 16, 2014

@Y75QMO you'll also probably want to add a link to the word list here: https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md

@Y75QMO
Copy link
Contributor Author

Y75QMO commented Oct 16, 2014

@voisine, I have added some comments regarding the Spanish wordlist and the link to the Spanish wordlist. Here is the pull request with the additions: #112

I am not sure my English is correct or the formatting is right. Please feel free to change my English if it can be improved.

@voisine
Copy link
Contributor

voisine commented Oct 16, 2014

@Y75QMO both this and #112 look good. I don't know if it's easier to add #112 to this PR or keep them separate, but the changes are fine. ACK

laanwj added a commit that referenced this pull request Oct 17, 2014
BIP0039 added Spanish wordlist
@laanwj laanwj merged commit d838202 into bitcoin:master Oct 17, 2014
@bentobox19
Copy link

@laanwj we found an alarming high number (80+) of potentially offensive words in the spanish file, which makes the list simply unusable:

https://zerobin.net/?49c8b750a5e169ec#5HlYfF26q5PJivUZRyZvGHj554Y6DYICcNO56kxqPpE=

Request advice on how to fix this. Should we create a spanish-v2.txt and just submit a Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants