[Test] Unit tests for contract module #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I've left some small comments. |
|
Updated addressing the review comments. Ready for next look. |
|
Sorry for taking so long to get back to this. One more nit left, feel free to ignore. Afterwards squish the commits into one with a commit message following these rules: https://chris.beams.io/posts/git-commit/ |
|
Thanks for the article. Really helpful. Updated as requested. Rebased and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some preliminary unit test cases for contract module.
Note:
I have updated the
read_locktime_from_contract()to read 8 byte i64 data, but I will cross verify with OP_CSV execution to write and read the correct data type from script.I have added an
read_pubkeys_from_contract_reedimscript()function as a helper, kept it because could be useful in future.I have skipped the method calls including
WalletandClient, planning to cover them in detail in separate module tests.Let me know if anything more needs to be added.