-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bux-246): Added linters #500
Conversation
Manual Testsπ Manual testing by @arkadiuszos4chain resulted in success. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 53.08% 53.08%
=======================================
Files 193 193
Lines 10895 10895
=======================================
Hits 5784 5784
Misses 4561 4561
Partials 550 550
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
β¦o BUX-246/Linters
β¦allet into BUX-246/Linters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should schedule a team meeting to discuss the whole topic.
Some brief summary (maybe as description of this PR) would be nice.
β¦o BUX-246/Linters
β¦o BUX-246/Linters
β¦o BUX-246/Linters
β¦o BUX-246/Linters
If everything is good. Will remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed for yamllint to start throwing warnings and treating them as errors?
It seems that yamllint have not checked these files |
Then we should configure yamlint to display warnings and treat them as such, not as errors. I don't like idea of adding '---' at the beginning of every YAML when we're not using directives. |
Changed |
Pull Request Checklist