Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore LN functionality with helm #664

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

pinheadmz
Copy link
Contributor

@pinheadmz pinheadmz commented Nov 6, 2024

  • Add charts for lnd. Deploy nodes and connect to bitcoind. Manually create channels and payments with RPC
  • Import channels from yaml or json with policy configurations
  • simln (may require new services abstraction)

@bdp-DrahtBot
Copy link
Collaborator

bdp-DrahtBot commented Nov 6, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #649 (speedy startup by willcl-ark)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@bdp-DrahtBot bdp-DrahtBot mentioned this pull request Nov 6, 2024
@pinheadmz pinheadmz force-pushed the ln-helm branch 2 times, most recently from 4b0bbc0 to d9aad8f Compare November 7, 2024 02:37
- mountPath: /root/.lnd/tls.cert
name: tlscert
subPath: tls.cert
{{- if .Values.circuitBreaker }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to have this removed before this PR is merged? Or shortly after? Circuit breaker feels like a service plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, this is leftover from Italy. ill need circuit breaker together with simln eventually either in this PR or a follow up, so this'll get cleaned up before merge

name: {{ include "lnd.fullname" . }}
name: tlskey
- configMap:
name: {{ include "lnd.fullname" . }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is finished but it looks like the same config map is mounted three times under three names.

Copy link
Contributor Author

@pinheadmz pinheadmz Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks will clean up

"max_htlc_msat",
]

for_fuck_sake_lnd_what_is_your_fucking_problem = {"min_htlc": "min_htlc_msat"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants