-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore LN functionality with helm #664
base: main
Are you sure you want to change the base?
Conversation
pinheadmz
commented
Nov 6, 2024
•
edited
Loading
edited
- Add charts for lnd. Deploy nodes and connect to bitcoind. Manually create channels and payments with RPC
- Import channels from yaml or json with policy configurations
- simln (may require new services abstraction)
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
4b0bbc0
to
d9aad8f
Compare
- mountPath: /root/.lnd/tls.cert | ||
name: tlscert | ||
subPath: tls.cert | ||
{{- if .Values.circuitBreaker }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plan to have this removed before this PR is merged? Or shortly after? Circuit breaker feels like a service plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, this is leftover from Italy. ill need circuit breaker together with simln eventually either in this PR or a follow up, so this'll get cleaned up before merge
name: {{ include "lnd.fullname" . }} | ||
name: tlskey | ||
- configMap: | ||
name: {{ include "lnd.fullname" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is finished but it looks like the same config map is mounted three times under three names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah thanks will clean up
"max_htlc_msat", | ||
] | ||
|
||
for_fuck_sake_lnd_what_is_your_fucking_problem = {"min_htlc": "min_htlc_msat"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an attempt to prevent the namespace test from failing.