Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update method parameter to take reference to PaymentHash #179

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Update method parameter to take reference to PaymentHash #179

merged 1 commit into from
Apr 22, 2024

Conversation

jrakibi
Copy link
Contributor

@jrakibi jrakibi commented Apr 14, 2024 •
edited
Loading

This PR addresses issue [#169] by updating the track_payment method in the LightningNode trait to accept a reference to PaymentHash instead of taking ownership

  • Changed method signature to &PaymentHash in the LightningNode trait.
  • Updated all implementations and usages of track_payment accordingly.

@carlaKC carlaKC self-requested a review April 22, 2024 13:29
carlaKC
carlaKC approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, thanks for the PR!

@carlaKC carlaKC merged commit a574b1e into bitcoin-dev-project:main Apr 22, 2024
2 checks passed
@carlaKC carlaKC mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlaKC carlaKC carlaKC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrakibi @carlaKC