test: Use Regex Search in Apptests #337
Conversation
jarolrod
force-pushed
the
regex-search-test
branch
from
d32b704 to
d342630
Compare
|
updated from d32b704 -> d342630 Changes:
|
| @@ -22,6 +22,7 @@ | |||
| #include <QAction> | |||
| #include <QEventLoop> | |||
| #include <QLineEdit> | |||
| #include <QRegularExpression> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I verified that Qt itself uses QRegularExpression header, at least for version we use in depends.
So, I'm ok with it.
jarolrod
force-pushed
the
regex-search-test
branch
from
d342630 to
1a63f44
Compare
|
updated from d342630 -> 1a63f44 (pr337.01 -> pr337.02) Changes:
|
jarolrod
force-pushed
the
regex-search-test
branch
from
1a63f44 to
9bde381
Compare
Allows for regex searching into the console output.
use the FindInConsole function to regex search for values in apptests instead of Univalue read.
jarolrod
force-pushed
the
regex-search-test
branch
from
9bde381 to
6969b2b
Compare
|
Updated from 9bde381 -> 6969b2b (pr337.03 -> pr337.04) Changes:
|
There was a problem hiding this comment.
ACK 6969b2b
Compiled the PR properly on Ubuntu 20.04
The PR introduces regex search functionality to apptest.cpp file by replacing univalue based search, which requires the qmessagewidget to be output in plaintext to work properly, with a more general Qregularexpression based search which doesn’t explicitly require a plaincheck to function.
Tested if the new apptest is running properly by running ./src/qt/test/test_bitcoin-qt and from there obtained: PASS : AppTests::appTests()
For the sake of completion, the final result obtained from running the test_bitcoin-qt file was:
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted, 96ms
This PR is an improvement over the master, as now the search string need not have to be a plaintext, which increases the number of use cases of the search action. An example of an additional use case is if we want to output the qmessagewidget in HTML to examine the values of the current HTML elements.
6969b2b qt, test: use regex search in apptests (Jarol Rodriguez) d09d1cf qt, test: introduce FindInConsole function (Jarol Rodriguez) Pull request description: This PR refactors our GUI `apptests` so that it uses regex search to find values in our console/qtextedit output regardless if it is in `plaintext`, `html`, or `markdown`. This introduces a new function `FindInConsole` which uses [QRegularExpression](https://doc.qt.io/qt-5/qregularexpression.html) to search the output of the console. The function must be provided with a [perl compatible regex](https://www.debuggex.com/cheatsheet/regex/pcre) pattern which wants to match a single group. The function then returns the matched group. If no match is found, an empty `QString` is returned. We then use this new function in `TestRpcCommand` to find the current `chain` value instead of reading with univalue. This approach can apply to a wider variety of testing scenarios as we can reuse this function to search for values when the console output is exported in a different format than `plaintext`. As an example, A follow up PR will add tests for console resizing and needs to look for the size in `html` tags after exporting the console text with `toHtml()`. ACKs for top commit: hebasto: ACK 6969b2b ShaMan239: ACK 6969b2b Tree-SHA512: 4db8bcd4a1acc4539ca64bbd7de572fe7dd6afc3e95108235abfc2891585bc4db3a56a33928fa38e8d44ac87023ce0dee3abcfadfbcd4440e3a21a52fef02536
This PR refactors our GUI
apptestsso that it uses regex search to find values in our console/qtextedit output regardless if it is inplaintext,html, ormarkdown.This introduces a new function
FindInConsolewhich uses QRegularExpression to search the output of the console. The function must be provided with a perl compatible regex pattern which wants to match a single group. The function then returns the matched group. If no match is found, an emptyQStringis returned.We then use this new function in
TestRpcCommandto find the currentchainvalue instead of reading with univalue.This approach can apply to a wider variety of testing scenarios as we can reuse this function to search for values when the console output is exported in a different format than
plaintext. As an example, A follow up PR will add tests for console resizing and needs to look for the size inhtmltags after exporting the console text withtoHtml().