Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Bump transifex slug for 22.x #286

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Apr 21, 2021

Opening the 22.x translations early because of experimentation with the new xliff translations format. So change the slug so that the tx tool will fetch the right translation.

In this context, change file_filter to use xlf as well as the files pulled with tx pull are that format now. The setting only affects the naming not the format of the files.

Opening the 22.x translations early because of experimentation with the
new xliff translations format.

In this context, change file_filter to `xlf` as well as the files
pulled with `tx pull` are that format now (the setting only affects the naming
not the format of the files).

Tree-SHA512: e0c18aa5e6cbd4428d24324fee8e5761b70dae51d0236277577aded719798c6a32fc81c0598f280321f2816629e33a334f61f9e7f6180c4074abfda6550cefbe
@hebasto
Copy link
Member

hebasto commented Apr 21, 2021

Concept ACK.

Are additional settings required on Transifex side? Or it will open 22.x translations automatically?

@laanwj
Copy link
Member Author

laanwj commented Apr 21, 2021

Are additional settings required on Transifex side? Or it will open 22.x translations automatically?

I've already done that (as you've noticed).

@laanwj
Copy link
Member Author

laanwj commented Apr 21, 2021

After this I'll add an additional step to the fetch script to use lconvert to convert the fetched .xlf files to .ts (then do the rest the same as now). I think that is all that is necessary.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4173059, I have reviewed the code and it looks OK, I agree it can be merged. All changes are in accordance with the Transifex docs.

@hebasto hebasto merged commit e7776e2 into bitcoin-core:master Apr 21, 2021
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants