refactor: Simplify SendCoinsDialog::updateCoinControlState #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebasto
changed the title
|
Concept ACK on simplifying code. |
hebasto
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
ACK 5f438d6, I have reviewed the code and it looks OK, I agree it can be merged.
I see this change as a nice bitcoin/bitcoin#18894 follow up.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 25, 2021
…eCoinControlState 5f438d6 refactor, qt: Simplify SendCoinsDialog::updateCoinControlState (João Barbosa) Pull request description: This PR doesn't change behaviour, removes the coin control argument from `updateCoinControlState` since it's a class member. ACKs for top commit: hebasto: ACK 5f438d6, I have reviewed the code and it looks OK, I agree it can be merged. jonatack: Code review ACK 5f438d6 kristapsk: utACK 5f438d6. Code looks correct. Tree-SHA512: 14abaa3d561f8c8854fed989b6aca886dcca42135880bac76070043f61c0042ec8967f2b83e50bbbb82050ef0f074209e97fa300cb4dc51ee182316e0846506d
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change behaviour, removes the coin control argument from
updateCoinControlStatesince it's a class member.