add onekey device support #709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A GHA run in my repo: https://github.com/OneKeyHQ/HWI/actions/runs/6212074159 |
|
@achow101 Please take care of this. Thxs |
achow101
reviewed
Nov 14, 2023
somebodyLi
force-pushed
the
gha
branch
4 times, most recently
from
4cf3346
to
d7df45f
Compare
|
the newest passed GHA https://github.com/OneKeyHQ/HWI/actions/runs/7110790185 |
|
Hello @achow101, we are still waiting to merge this PR, we have already rebased to latest commit and addressed questions and issues above. Could you kindly reveiw again base on our latest commit? |
|
Can you please rebase it? |
somebodyLi
force-pushed
the
gha
branch
2 times, most recently
from
cdf99d9
to
e4ac963
Compare
Of course, But there seems to be a problem with the simulator's compilation dependency installation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.