Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance stop swarm process #468

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Enhance stop swarm process #468

merged 3 commits into from
Nov 2, 2023

Conversation

nsosio
Copy link
Contributor

@nsosio nsosio commented Nov 2, 2023

Fixes #464 by:

  • properly retrieving swarm processes as a Vec<u64>
  • SIGTERM with timeout before SIGKILL process

@nsosio nsosio added the enhancement New feature or request label Nov 2, 2023
@nsosio nsosio requested a review from casperdcl November 2, 2023 15:23
@nsosio nsosio self-assigned this Nov 2, 2023
@nsosio nsosio force-pushed the feat/swarm-process-deletion branch from e5becd2 to ecb4ad7 Compare November 2, 2023 15:26
casperdcl
casperdcl approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nsosio nsosio requested a review from tiero November 2, 2023 16:14
@tiero tiero merged commit 05faeda into bit-gpt:main Nov 2, 2023
1 check passed
@nsosio nsosio deleted the feat/swarm-process-deletion branch December 3, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

@tiero tiero Awaiting requested review from tiero

Assignees

@nsosio nsosio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Petal processes kill
3 participants
@nsosio @casperdcl @tiero