Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker auto-update #458

Closed
wants to merge 2 commits into from
Closed

docker auto-update #458

wants to merge 2 commits into from

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Nov 1, 2023

@@ -1,18 +1,18 @@
version: '3.7'
services:

premapp:
container_name: premapp
prem_app:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why this is necessary?

Copy link
Contributor Author

@casperdcl casperdcl Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just using the same convention as the base docker-compose.yml file :)

alternatively would have to get watchtower to monitor both premapp and prem_app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok, I think this docker-compose may be outdated and not really used for dev or prod either AFAIK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well I use it for dev. @filopedraz shouldn't we use it for demo.prem.ninja too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this service belongs to the actual server installation for production, you premapp is the one used in the compose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl I am using prem-box installer script for demo.prem.ninja :)

@tiero
Copy link
Contributor

tiero commented Nov 1, 2023

Thank you! this seems to be a better solution than a hand-made solution.
I think this PR should be opened in prem-box as this is more geared toward a production scenario, rather development one.

@casperdcl
Copy link
Contributor Author

casperdcl commented Nov 1, 2023

ah I don't quite understand the use-case of prem-box, i.e. why not merge all the config from prem-box into this repo (prem-app)?

@tiero
Copy link
Contributor

tiero commented Nov 1, 2023

ah I don't quite understand the use-case of prem-box,

It's the repository dedicated to centralizing installer script, the latest stable versions, and docker-compose files used for the server installation 👉 https://dev.premai.io/docs/prem-app/installation/install-linux-production

i.e. why not merge all the confign from prem-box into this repo (prem-app)?

We are going to change the project structure very soon, for now, let's stick with what we have already in place

@casperdcl
Copy link
Contributor Author

moved to premAI-io/prem-box#33

@casperdcl casperdcl closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants