This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Change type of obstacle message callback #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texhnolyze
approved these changes
Jan 16, 2023
|
Regarding future work, I talked to @Flova and he said that the vision already uses the robot messages and never publishes obstacle messages, so we only need to change it here and can drop the obstacles. |
|
I think the obstacle and robot messages are both interesting and ideally we would communicate both. But currently we only detect robots so this is definitely prioritized. |
|
What's the status of this PR? Do we want/need to continue with it? |
|
I think it has been superseded by #127 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related to #125. This change is not a solution but changes the subscription to avoid the message type conflict.