Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/gpu system monitor #619

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Feature/gpu system monitor #619

merged 11 commits into from
Nov 14, 2024

Conversation

HR05
Copy link
Contributor

@HR05 HR05 commented Nov 11, 2024 •
edited
Loading

Summary

  • implement gpu metrics in system monitor

Checklist

  • Run colcon build
  • Write documentation
  • Test on your machine
  • Test on the robot
  • Create issues for future work
  • Triage this PR and label it

@HR05 HR05 requested a review from Flova November 11, 2024 19:37
@Flova Flova added misc enhancement New feature or request labels Nov 11, 2024
Flova
Flova reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@Flova Flova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, but I have a few additions that would be nice to have :)

bitbots_misc/system_monitor/system_monitor/gpu.py Outdated Show resolved Hide resolved
bitbots_misc/system_monitor/system_monitor/gpu.py Outdated Show resolved Hide resolved
bitbots_misc/system_monitor/system_monitor/monitor.py Show resolved Hide resolved
@HR05 HR05 self-assigned this Nov 14, 2024
Flova
Flova reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@Flova Flova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me.

bitbots_misc/system_monitor/system_monitor/cpus.py Outdated Show resolved Hide resolved
@HR05 HR05 requested a review from Flova November 14, 2024 20:32
@HR05 HR05 marked this pull request as ready for review November 14, 2024 20:51
@Flova Flova merged commit 534c728 into main Nov 14, 2024
2 checks passed
@Flova Flova deleted the feature/gpu_system_monitor branch November 14, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flova Flova Flova approved these changes

Assignees

@HR05 HR05

Labels
enhancement New feature or request misc
Projects
Software
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HR05 @Flova