Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git filter for selected lines in vscode config json #332

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

Flova
Copy link
Member

@Flova Flova commented Jan 27, 2024

Summary

The VS Code ROS extension always adds a bunch of user specific absolute paths to the vscode settings json. This results in every user having uncommitted changes by default. Accidentally committing them is also annoying. We therefore add a rule to git that ignores said files.

Proposed changes

  • Add .gitattributes file that applies a custom filter on the settings file
  • Add a custom filter rule that deletes lines containing absolute home directory paths from the given file.
  • Install the custom filter with update make targets
  • Also remove ros.rosSetupScript key from config as the extension did not work properly when is contained env variables, this was not an issue with previous versions of vscode. But it somehow discovers it without it in my version so I guess removing it is fine. Needs testing on other machine tho..

@jaagut jaagut merged commit 56011d7 into main Jan 29, 2024
2 checks passed
@jaagut jaagut deleted the git_filter branch January 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants