Add git filter for selected lines in vscode config json #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The VS Code ROS extension always adds a bunch of user specific absolute paths to the vscode settings json. This results in every user having uncommitted changes by default. Accidentally committing them is also annoying. We therefore add a rule to git that ignores said files.
Proposed changes
.gitattributes
file that applies a custom filter on the settings fileupdate
make targetsros.rosSetupScript
key from config as the extension did not work properly when is contained env variables, this was not an issue with previous versions of vscode. But it somehow discovers it without it in my version so I guess removing it is fine. Needs testing on other machine tho..