Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading theme does not show error when file name is incorrect #28

Closed
danieljsummers opened this issue Aug 19, 2022 · 1 comment
Closed

Uploading theme does not show error when file name is incorrect #28

danieljsummers opened this issue Aug 19, 2022 · 1 comment
Assignees
@danieljsummers
Labels
bug
Milestone
v2

Comments

@danieljsummers
Copy link
Collaborator

Error messages are not displayed when a theme file that does not end in -theme.zip is uploaded.
@danieljsummers danieljsummers added this to the v2 milestone Aug 19, 2022
@danieljsummers danieljsummers self-assigned this Feb 6, 2023
danieljsummers added a commit that referenced this issue Feb 9, 2023
@danieljsummers
Show theme upload messages (#28)
1963d22
@danieljsummers
Copy link
Collaborator Author

No messages were being displayed for theme uploads, as the JavaScript on the client side was only run for an htmx response. File uploads must use a standard request/response. This now works both for messages pre-rendered on the server and those passed in response headers.

danieljsummers added a commit that referenced this issue Feb 26, 2023
@danieljsummers
v2 (#36)
7b325dc 
* Use PostgreSQL JSON-based data implementation
* Fix back link on RSS settings page (#34)
* Show theme upload messages (#28)
* Fix admin page list paging (#35)
* Add db migrations for all stores
* Support both .NET 6 and 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljsummers danieljsummers

Labels
bug
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@danieljsummers