Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee reimbursement for trade BLobJUX #60

Closed
cbeams opened this issue Jan 24, 2018 · 31 comments
Closed

Fee reimbursement for trade BLobJUX #60

cbeams opened this issue Jan 24, 2018 · 31 comments
Assignees

Comments

@cbeams
Copy link
Contributor

cbeams commented Jan 24, 2018

This issue has been created per the process detailed in #35 to track the reimbursement of trading and mining fees lost due to the 'failed transaction broadcast' problem tracked at bisq-network/bisq#1193, investigated at bisq-network/bisq#1195, and now fixed in Bisq v0.6.4 with the resolution of bisq-network/bisq#1244.

IMPORTANT: If you have not yet upgraded to Bisq v0.6.4, please do so immediately at https://bisq.network/downloads.

If the trade ID in the title of this issue is yours, then please click the Subscribe button in the right menu of this issue to be notified about the status of your reimbursement.

If you do not see a Subscribe button, then you are not logged in to GitHub. Please log in or create an account if necessary. You'll then be able to Subscribe to this issue and you will get updates by email.

NOTE: this issue was created in response to @jenechka1 at #35 (comment), not as part of the usual process laid out in #35. This trade appears to belong to @keo-bisq as I do not have it in my arbitration queue, and because @jenechka1 mentioned that they'd already seen a "blanket" close mention that referenced a different reimbursement issue (#53)—I imagine that was due to copy-and-paste error when @keo-bisq was closing this trade out.

@cbeams
Copy link
Contributor Author

cbeams commented Jan 24, 2018

@jenechka1, could you please paste a screenshot of the trade details screen where it shows the Maker, Taker and Deposit transaction IDs, and also paste those transaction IDs here as text? Thanks.

@cbeams
Copy link
Contributor Author

cbeams commented Jan 24, 2018

And for an example of the information I'm requesting above, see #53 (comment)

@jenechka1
Copy link

@cbeams, my screen is a small one, so it does not all fit, but here it is anyway.
screen shot

Maker: e46ad0efeecb48d3f0151404aaf13c86074f06783e15367f4ffbe9b30deb4a99
Taker: 821f7324acc86f41f02d4a55ac9bcf376a03d8c5cc8a81020e8ed7712cb56698
Deposit: ff888a5747c325529c17cb6573c82c541a6c221d34c585c819379b226b4f873b

@cbeams
Copy link
Contributor Author

cbeams commented Jan 24, 2018

Perfect, thank you.

@jenechka1
Copy link

The trade is still open and shows a little over 20 hours remaining. Do I need to do anything else at this time? Or do I wait for further instructions?

@cbeams
Copy link
Contributor Author

cbeams commented Jan 25, 2018

@jenechka1, I was under the impression (from your comment in #35) that this trade had already gone to arbitration and already been closed. Yet above, you say it is still open with 20 hours remaining. What am I missing?

@cbeams
Copy link
Contributor Author

cbeams commented Jan 25, 2018

And in any case (regardless the answer to the question above), the maker and deposit transactions for this trade have not been broadcast, meaning it is impossible to complete this trade. The only thing left to do is to reimburse the maker fee transaction, which will be done as part of the resolution of this issue. You can just stand by for that.

But I am curious as to why this issue is "still open" on your client. If you saw a "close ticket" message in arbitration chat, this trade should be closed. Feel free to share screenshots of your Portfolio screens so we can track this down. And you can send these to me via email to [email protected] or via Keybase to @cbeams if you prefer for privacy.

@jenechka1
Copy link

The trade did not go to arbitration. I didn't know it could before the time ran out. Instead, I opened a support ticket, having read about the bug on bisq.community forum.

I'm sending screenshots to your email in a few.

@cbeams
Copy link
Contributor Author

cbeams commented Jan 29, 2018

Staged for reimbursement in b902362

cbeams added a commit that referenced this issue Jan 29, 2018
@cbeams cbeams self-assigned this Jan 29, 2018
@cbeams
Copy link
Contributor Author

cbeams commented Jan 31, 2018

Closing as reimbursed via the batch transaction documented at #35 (comment).

@cbeams cbeams closed this as completed Jan 31, 2018
@jenechka1
Copy link

screen shot 2018-01-31 at 2 31 46 pm

@cbeams
Copy link
Contributor Author

cbeams commented Jan 31, 2018 via email

@ManfredKarrer
Copy link

@jenechka1 Please try to delete the spv chain file. Use the just released 0.6.5 version as there is an important fix regarding spv file deletion on Windows.

@jenechka1
Copy link

Do I have to be in the app in order to do that? Because I can't get into the app. After I dismiss that warning about duplicate transactions, here is what I see:
screen shot 2018-01-31 at 11 12 52 pm

I did download the latest, but just so you know, I'm on MacOS High Sierra (10.13.2)

@jenechka1
Copy link

jenechka1 commented Feb 1, 2018

Found a file "bisq.spvchain" in "~/Library/Application Support/Bisq/btc_mainnet/wallet".
Deleted it, then attempted to restart the app. Same warning followed by "connection failed".

What do I do? I have trades, which are paid for, but which I suspect will not complete because of another issue (referenced here: #1174 They may be in arbitration, but I have no way of checking.

Is now a good time to panic?

@jenechka1
Copy link

Not to rush you guys, but time is of the essence. Is there anything else you can think of that I could do to gain access to my wallet and trades?

@cbeams
Copy link
Contributor Author

cbeams commented Feb 2, 2018

@jenechka1, what happens if you do the following?

$ /Applications/Bisq.app/Contents/MacOS/Bisq --appName=Bisq-Test

This will start Bisq against a completely fresh application data directory (at ~/Library/Application Support/Bisq-Test), and won't have any effect on your earlier installation.

Based on what you discover here, we can see about next steps.

P.S.: We should really be managing this in a separate issue, but for now I'm just quickly re-opening this one. Hopefully we can sort this out quickly and re-close.

@cbeams cbeams reopened this Feb 2, 2018
@jenechka1
Copy link

It started up fine, but without any information about my trades / wallet / settings. What exactly are we looking for?

@cbeams
Copy link
Contributor Author

cbeams commented Feb 2, 2018

Ok, good. This proves that your machine / network is capable of running Bisq, connecting to the network etc.

Here's what we should do next:

  1. Close the Bisq-Test instance if it's still open. You won't need it anymore.
  2. Download and install Bisq v0.6.5 from https://bisq.network/downloads
  3. Try to run the newly installed version just as you usually do, i.e. by double clicking on the Bisq icon
  4. Let it try to start up for at least 3 minutes
  5. If Bisq has not correctly started up by that time, then please attach your bisq.log file here. You can find it at ~/Library/Application Support/Bisq/bisq.log. I'll then analyze the log and get back to you.

@jenechka1
Copy link

So, still get this message:
screen shot 2018-02-02 at 10 36 45 am

When I dismiss it, the app just hangs here for a few minutes:
screen shot 2018-02-02 at 10 39 08 am

And then eventually goes here:
screen shot 2018-02-02 at 10 39 42 am

I tried deleting Tor files, going with bridges... nothing changes.

I'm attaching the log file you requested. There is another one there: bisq_1.log; let me know if you need it.
bisq.log

@cbeams
Copy link
Contributor Author

cbeams commented Feb 2, 2018

@ManfredKarrer, it still seems to me that this "duplicate transaction" problem has to be solvable by resyncing SPV. @jenechka1 said in #60 (comment) that he tried manually removing the SPV file. Could you double-check that comment and provide any advice? Thanks.

@cbeams
Copy link
Contributor Author

cbeams commented Feb 3, 2018

@jenechka1, I've just gone through the code and verified that deleting bisq.spvchain manually should be all that you need to do. I've just tested this myself as well, and I was able to get back into the app as expected.

Let me double-check something here: when you deleted the bisq.spvchain file before, was the Bisq application already closed, or did you close it after deleting the file?

My recommendation is this: Make sure Bisq is shut down fully, remove the bisq.spvchain once more, and start the app once more. Let me know what happens. Thanks.

@jenechka1
Copy link

With Bisq app closed I am moving bisq.spvchain from /Bisq/btc_mainnet/wallet to the Desktop with this command: mv bisq.spvchain ~/Desktop/

Then attempt to start the Bisq app.

The behavior is exactly as described in my previous message above.

Also, you may find this useful: the bisq.spvchain file does not get regenerated.

@jenechka1
Copy link

Guys (@cbeams, @ManfredKarrer) , any chance finding a solution to this may get a higher priority? I am unable to access neither my wallet nor the trades for three days now. As I'm sure you understand - time is of the essence.

@cbeams
Copy link
Contributor Author

cbeams commented Feb 4, 2018

I've pinged @ManfredKarrer about this off-thread, @jenechka1. We'll get back to you, thanks.

@ManfredKarrer
Copy link

@jenechka1 Can you send me the log file (manfred at bitsquare dot io - please reference to that GH issue)? Which OS are u using? On Windows you cannot delete the file if Bisq is running. After you have deleted it was the file newly created and did have the current date?
If the file was really newly created and the issues did not disappear you can try to restore from seed words.
First make a backup then go to account/seed words and copy the seed words and date. Then use the same to restore it in the same screen. After restore the spv file will be resynced as well.
Hope that helps.

@jenechka1
Copy link

jenechka1 commented Feb 4, 2018 via email

@jenechka1
Copy link

@ManfredKarrer, so I moved the Bisq directory from ~/Library/Application Support/Bisq, then I started the app again and it opened up with all the startup dialogs etc. Then I made a backup and restored with my seed words from before. Now, the only thing that appears to have re-synched is the list of transactions.

I had a number of open trades, but none of them appear under "Portfolio". I had an open offer, it's not there anymore. All of "Available balance", "Reserved in offers", "Locked in trades" are showing 0.0, even though they all had non-zero values before.

What else can I do?

@jenechka1
Copy link

@cbeams, @ManfredKarrer

I think I have gotten it back to where I want it to be. Here are the steps:

  • Removed the spvchain file. Actually, I don't think this did anything for this particular issue, because the warning kept appearing and I was still unable to enter the app, even after it was removed, but, for the sake of completeness I thought it important to mention that it was removed.

  • Made a backup copy of the ~/Library/Application Support/Bisq directory, and then deleted this directory from ~/Library/Application Support/

  • Ran Bisq and restored the wallet from seed words.

  • Once the wallet completed its synchronization, copied the BTC.wallet file to the backup, created in step two above, replacing the corrupt one.

  • Removed the ~/Library/Application Support/Bisq directory again, but this time, put the backup, created in step two, back to take its place.

  • Ran the Bisq app again. It took a few minutes to synchronize, but it appears to have picked up all the changes to my wallet, including from the trades that were opened when the problem began and that completed while I was still unable to access the app.

Thank you for your help.

@cbeams
Copy link
Contributor Author

cbeams commented Feb 5, 2018

Excellent! Very glad to hear that. I'll respond to you via our email thread as well. All the best.

@cbeams
Copy link
Contributor Author

cbeams commented Feb 6, 2018

Re-closing as @jenechka1's issues are now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants