Apply changes from code we received from a retired Bisq dev #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we don't have a git version to know on which version was based on, it was hard to merge. I tried to not delete any files from latest snapshot (before Bisq got removed from mempool) and I tried to keep new changes which are likely unreleated to his changes. Though its messy and requires a dev familiar with the used tech stack to clear all that up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't have a git version to know on which version was based on, it was hard to merge. I tried to not delete any files from latest snapshot (before Bisq got removed from mempool) and I tried to keep new changes which are likely unreleated to his changes. Though its messy and requires a dev familiar with the used tech stack to clear all that up.
This draft PR is just for guidance for a developer who can implement the changes based on our current master branch.