This repository has been archived by the owner on Jan 10, 2021. It is now read-only.
Merge bisq/master #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't return 0 in the case of a null 'this.id' field, as that violates the Comparable contract and leads to inconsistent NPE throwing when the arguments are swapped. Instead, just assume (reasonably) that the ID field will never be null.
Remove the flawed pattern of returning 0 in a comparator when the sub- field of one of the two inputs being compared is null or absent. This violates the Comparator contract, since returning 0 or otherwise should define an equivalence relation. Use Comparator.nullsFirst(..) in the table column comparators instead, to ensure consistent ordering when a cell is missing a value. This fixes ill-defined and erratic behaviour in the underlying merge/insertion sort of the table rows done by the FX library.
Do not remove the proposals table when VoteResultView is deactivated, as the cycle selection which triggered its display is still active upon switching to another screen and back again. This fixes #3269. Also remove a spurious 'GUIUtil.removeChildrenFromGridPaneRows' call when a proposal result is selected, as it is no longer needed since switching from an inline votes table to a popup.
* Fix broken placeholders * Replace non existing pending trades screen with open trades screen * Update core/src/main/resources/i18n/displayStrings.properties Co-Authored-By: Steve Jain <[email protected]> * Update message in failed trade popup
Remove unused stuff from Utilities
Refactor BisqApp - move icon load into ImageUtil
Refactor BisqApp - update error popup message build
…culation Refactor BisqApp - update scene size calculation
Remove not used private methods from BisqEnvironment
- Official project URL: https://ndau.io/ - Official block explorer URL: https://explorer.service.ndau.tech
Refactor BisqEnvironment
List Krypton (ZOD)
Show connected Bitcoin network peer info
List Ndau (XND)
List Animecoin (ANI)
Check for dust after subtracting fee, not before.
Fix proposal table hide when switching to another screen and back
Refactor BisqEnvironment - use @Getter annotation for appDataDir
Refactor BisqEnvironment - create getListProperty
Remove donation link
Fix BTC valuation popups
Remove duplicate word in user agreement
Launch in Limbo with BisqException when last navigation no longer exists
Release/v1.2.2
* Update seednode systemd service, move env vars to separate file * Update seednode README
Refactor BisqEnvironment - change type of ignoreLocalBtcNode to boolean
Add missing network capability for trade statistics hash update
Update tor, netlayer, jtorctl
List LBRY Credits (LBC)
…es (#3562) * Limit max. nr. of PersistableNetworkPayload and ProtectedStorageEntry to 10000 To avoid that seed nodes get overloaded with requests for too many PersistableNetworkPayload and ProtectedStorageEntry data we limit nr. of entries to max 10000. * Add peers node address to logs * Improve logs - Add log of size to GetBlocksResponse.toProtoNetworkEnvelope method - Log in kb * Log connection UID if not peer address available * Add cleanup code or invalid objects We have an invalid Filter object in the live network (prob. some dev made some mistake). This code helps so clean that up. * Add log
* Improve handling of failed trades and offers - Check if deposit tx is null - Check if trade fee tx is rejected - Listen to reject tx errors - Cleanup addressEntryList - Prevent opening disputes with if deposit tx is null - Add null checks - Improve logs - Cleanups * Add move to failed trade button to popup In case the deposit tx is null we show a popup telling the user to move the trade to failed trades after a restart if the problem persist. * Change log level
* Rename: PeerInfoIcon makersAccount -> peersAccount * Fix peer info in trade view peerinfoicon popup, fix #3548
* Bump version number * Revert to SNAPSHOT version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.