Skip to content
This repository has been archived by the owner on Jan 10, 2021. It is now read-only.

Configure integration tests #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Configure integration tests #14

wants to merge 1 commit into from

Conversation

blabno
Copy link
Contributor

@blabno blabno commented Oct 14, 2019

Resolves #5

@blabno blabno requested review from wiz and mrosseel October 14, 2019 05:41
@blabno blabno requested a review from ripcurlx as a code owner October 14, 2019 05:41
@blabno blabno changed the title Configure integration tests #5 Configure integration tests Oct 14, 2019
lusarz
lusarz reviewed Oct 14, 2019
View reviewed changes
Copy link

@lusarz lusarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small points to discuss

api/src/testIntegration/java/bisq/api/http/UserEndpointIT.java Outdated Show resolved Hide resolved
api/src/testIntegration/java/bisq/api/http/UserEndpointIT.java Outdated Show resolved Hide resolved
api/src/testIntegration/java/bisq/api/http/VersionEndpointIT.java Show resolved Hide resolved
api/src/testIntegration/java/bisq/api/http/RegexMatcher.java Outdated Show resolved Hide resolved
api/src/testIntegration/java/bisq/api/http/ContainerFactory.java Show resolved Hide resolved
api/src/testIntegration/java/bisq/api/http/arguillian/CubeLoggerExtension.java Outdated Show resolved Hide resolved
@blabno blabno force-pushed the api-integration-tests branch from 2b06178 to 33c41e6 Compare October 15, 2019 03:37
@blabno blabno force-pushed the api-integration-tests branch from 33c41e6 to 683530d Compare October 15, 2019 08:28
@blabno
Copy link
Contributor Author

blabno commented Nov 6, 2019

@ripcurlx can you review and merge this PR, it already went under thorough review from @lusarz?

This was referenced Nov 9, 2019
Open
Open
@lusarz lusarz mentioned this pull request Nov 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lusarz lusarz lusarz approved these changes

@wiz wiz Awaiting requested review from wiz

@mrosseel mrosseel Awaiting requested review from mrosseel

@ripcurlx ripcurlx Awaiting requested review from ripcurlx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure integration tests
2 participants
@blabno @lusarz