Skip to content
This repository has been archived by the owner on Jan 10, 2021. It is now read-only.

Add Docker support #12

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Add Docker support #12

merged 1 commit into from
Oct 14, 2019

Conversation

blabno
Copy link
Contributor

@blabno blabno commented Oct 10, 2019

No description provided.

@blabno blabno requested review from wiz and mrosseel October 10, 2019 05:55
@blabno blabno requested a review from ripcurlx as a code owner October 10, 2019 05:55
@mrosseel
Copy link
Contributor

looks good, one remark - for the seednodes I've been doing some docker work as well, and I've now partially switched from using the startApi.sh style and directly putting the arguments in docker-compose, using the 'command:' feature. These get added to the end of the entrypoint, which can be gradlew in this case. Futhermore, the values of these arguments can be hard-coded as now or defined in a .env file, so that the user doesn't have to touch the docker-compose.yml. This would eliminate the shell script and avoid having to change in two places if an argument changes/gets added. For an example see the btcd service in my seednode branch

@blabno
Copy link
Contributor Author

blabno commented Oct 10, 2019

@blabno
Copy link
Contributor Author

blabno commented Oct 10, 2019

I'm open to experimenting in future, however since approach in this PR works I would like to proceed this way to get something usable for users.

@mrosseel
Copy link
Contributor

@mrosseel I still see bash script to start: https://github.com/mrosseel/bisq/blob/dao-seednode/seednode/docker/prod/Dockerfile#L25

yes, as mentioned I use the technique for the btcd service. Not a blocking thing, but certainly a TODO to remove the unnecessary script.

utACK

api/docker-compose-base.yml Outdated Show resolved Hide resolved
@blabno blabno merged commit ede7f1b into bisq-network:master Oct 14, 2019
@blabno blabno deleted the api-docker branch October 14, 2019 05:05
@blabno blabno mentioned this pull request Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants