Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 36 #1074

Closed
alvasw opened this issue May 25, 2022 · 5 comments
Closed

For Cycle 36 #1074

alvasw opened this issue May 25, 2022 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented May 25, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 3192.62
  • USD requested: 3895
  • BSQ rate: 1.22 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 34 #1030

My last compensation request was not properly broadcasted to the network. The compensation request never ended up in a block (see #1055 (comment)).

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Wallets: Include Unconfirmed Balance in getBalance method dev 15 bisq-network/bisq2#279
Wallet: Save WalletFile by default in data directory dev 10 bisq-network/bisq2#280
Wallet: Remove NetworkType Enum (Regtest, Signet, Testnet, ...) dev 20 bisq-network/bisq2#281
WalletConfig: Make hostname and port mandatory dev 5 bisq-network/bisq2#282
Split WalletService into BitcoinWalletService and LiquidWalletService dev 750 bisq-network/bisq2#308
  • Add RpcConfig verification
  • Split RpcConfig into DaemonRpcConfig and WalletRpcConfig
  • Add Wallet submenu in UI for both cryptocurrencies
  • Split WalletStore into BitcoinWalletStore and LiquidWalletStore
  • Persist RPC config after verifying whether they are correct
Split wallets module into submodules and centralize Gradle configuration dev 1050 bisq-network/bisq2#315
  • Create standalone Gradle Plugin module
  • Gradle: Set version in bisq.java-library
  • Gradle: Set logging dependencies in bisq.java-library
  • Create bisq.protobuf Gradle project type
  • Remove buildSrc module
  • Split wallets module into submodules
    • core
    • bitcoind
    • elementsd
    • regtest
  • Split build-logic module into commons and regtest
  • Gradle: Remove repositories block from root build.gradle
Gradle: Add all libraries to central version catalog dev 30 bisq-network/bisq2#321
Simplify Gradle Configurations dev 40 bisq-network/bisq2#324
  • Gradle: Set protobuf plugin version globally
  • Remove api project common-platform (already set in custom project)
  • Remove api project common-platform (already set in custom project)
  • Remove duplicate dependency constraint enforcements
Cleanup wallets modules dev 20 bisq-network/bisq2#330
  • Apply Gradle Regtest Plugin only to desktopapp
  • Fix broken :wallets:regtest modules
  • wallets.regtest: Remove unused dependencies
  • wallets: Use global protobuf configuration
  • Update jackson-lib to 2.13.3
  • Remove java plugin from root build.gradle
Gradle Regtest: Add networkServiceConfig JVM args dev 4 bisq-network/bisq2#203 Cycle 35
Fix all broken regtest tasks.
Bitcoind: ZeroMQ Support + Auto-Update Balance in DesktopApp dev 1200 bisq-network/bisq2#206 Cycle 35
  • Consumers can register listeners when:
    • a new block gets mined
    • a UTXO is spent
    • a receive address received money
  • Auto-Update balance in UI
Gradle: Create custom project type 'bisq.java-library' dev 30 bisq-network/bisq2#215 Cycle 35
Move all common Gradle settings to a global project type.
Add Elementsd ZeroMQ Support dev 650 bisq-network/bisq2#230 Cycle 35
  • Consumers can register listeners when:
    • a new block gets mined
    • a UTXO is spent
    • a receive address received money
  • Unblind transactions before processing
  • Auto-Update balance in UI
Github Actions: Enable CI dev 15 bisq-network/bisq2#235 Cycle 35
Github Actions: Enable Dependabot dev 1 bisq-network/bisq2#236 Cycle 35
Gradle: Regtest Task Configuration Avoidance (lazy init) dev 30 bisq-network/bisq2#241 Cycle 35
At the moment, every Gradle run hits the disk to check for the regtest files and initializes these if they don't exist. This is bad for performance, and we shouldn't do it. This change lazily initializes all regtest tasks. For more information, see: https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
Update to Java 17 dev 15 bisq-network/bisq2#254 Cycle 35
Gradle: Enforce Compilation with Java 17
Gradle: Global JUnit 5 Setup dev 10 bisq-network/bisq2#255 Cycle 35
Setup JUnit 5 globally in custom project type.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels May 25, 2022
@MwithM MwithM added this to the Cycle 36 milestone May 26, 2022
@ripcurlx
Copy link
Contributor

@chimp1984 Could you please ACK this CR for the Bisq2 contributions? Thanks!

@chimp1984
Copy link

ACK

@ripcurlx
Copy link
Contributor

As dev team lease I approve this compensation request for dev based on #1074 (comment). Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@alvasw
Copy link
Author

alvasw commented May 31, 2022

7e9751e8b004d54859f8e479b2c67b8a122e4b9e33c52c0288532ff4e3fa122b

@MwithM MwithM added the was:rejected Indicates that a compensation request was rejected by DAO voting label Jun 10, 2022
@MwithM
Copy link
Contributor

MwithM commented Jun 10, 2022

Was rejected due to lack of quorum.

@MwithM MwithM closed this as completed Jun 10, 2022
@MwithM MwithM added was:accepted Indicates that a compensation request was accepted by DAO voting parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid was:accepted Indicates that a compensation request was accepted by DAO voting labels Jun 10, 2022
@alvasw alvasw mentioned this issue Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants