Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check roles using mempool tx lookup. #92

Merged
merged 3 commits into from Feb 10, 2022
Merged

Check roles using mempool tx lookup. #92

merged 3 commits into from Feb 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2022

Closes #68

chimp1984
chimp1984 suggested changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contentwise it looks all good! Some smaller nits...

social/src/main/java/bisq/social/userprofile/BsqTxValidator.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/BtcTxValidator.java Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/BtcTxValidator.java Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
social/src/main/java/bisq/social/userprofile/UserProfileService.java Outdated Show resolved Hide resolved
chimp1984
chimp1984 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost
Copy link
Author

ghost commented Feb 10, 2022

After 2 days fighting KeyGeneration.java and SignatureUtil.java I cannot get Bisq2 to successfully verify Bisq1 (bitcoin) signatures. Leaving it as is for now.

@ghost ghost marked this pull request as ready for review February 10, 2022 19:54
chimp1984
chimp1984 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984
Copy link
Contributor

No worry I will look into it later...

@chimp1984 chimp1984 merged commit 3f4bfa3 into bisq-network:main Feb 10, 2022
@ghost ghost mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Entitlement verifications
1 participant
@chimp1984