Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mediation handling #613

Merged
merged 9 commits into from
Dec 22, 2022

Conversation

HenrikJannsen
Copy link
Contributor

No description provided.

…s byte arrays of payload and could fail otherwise
…ave deterministic behaviour.

The proof or work check compares the payload bytes and not deterministic sorting in collections would cause random failures.
We use generic sorting of the byte array of the serialized data.
Rename mediationActivated to inMediation
Fix display names and icons when in mediation
PrivateTradeChannel is either a 2 party channel of both traders or a 3 party channel with 2 traders and the mediator.
Depending on the case the fields are differently interpreted.
Maybe we should model a group chat channel for a cleaner API.
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 7f652b0 into bisq-network:main Dec 22, 2022
@HenrikJannsen HenrikJannsen deleted the fix_mediation_handling branch December 29, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants